Repository navigation
Conversation
added 4 commits
October 8, 2026 18:36
…-era statics (#758, slice 2) Thread &AppCaches through load_config, quarantine/conflict emitters, tray rebuild/paint helpers, and every window/config/updater/snooze caller; delete CONFIG_QUARANTINED, CONFLICT_EVENT_SENT, tray cache statics and QUARANTINE_TEST_LOCK; fix the Tauri 2.11 event-listener handle capture; add test_two_app_states_do_not_share_caches. LOCALE_TEST_LOCK survives (i18n::CURRENT is an issue-blessed keep). No behaviour change in the single-session path.
#758, slice 2) - listener consumes on emitter thread (spawn raced the rebuild, could paint stale Play/Pause on same-track pause); guard pins inline shape - delete dead MODE_ATOM_LOCK imports + static (zero live uses) - repoint LAST_*_STATE refs to playing/shuffle/repeat_flag accessors
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slice 2 of the behavioural-statics move: tray caches/mirrors + config quarantine/conflict flags now owned from AppState (SessionState carries AppCaches), QUARANTINE_TEST_LOCK deleted, MODE_ATOM_LOCK deleted. Isolation test proves two AppStates do not share caches. No behaviour change in the single-session path.
PARTIAL for #758 — do NOT close: LOCALE_TEST_LOCK survives (i18n::CURRENT stays process-wide per the issue step-3 keeps list); locale-table ownership is slice-3 scope.
What changed
Tests
Review
Two independent critics scored the tree: 97/100 (2 comment-only gaps, both fixed) and 88/100 (P1 spawn-race, now inline with a guard; dead lock/static refs cleared). All gaps closed and re-verified (tray 36/36, lib 913/913).