Repository navigation
Conversation
…vioural tests (#778, partial)
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#398 snapshot guard is now behavioural (held-section per-slot
try_writeprobe, fail-closed; offload equality on non-empty state); tray click ordering moves into pureTrayClickTarget. Every surviving scan in the 8 touched files carries a why-not comment. Prose reword can no longer fail the suite.PARTIAL: ~25 scans tree-wide remain unannotated; reorder-mutation proof is the follow-up. No
Closeskeyword — #778 stays open.Review
Two independent post-fix 100/100 MERGE-PARTIAL verdicts (Critic778c + Critic778d). Prior rounds: 58/FIX (5 gaps) → fixed → 88/FIX (2 gaps) → fixed.
Verification
cargo test --lib: 912 passedcargo check/clippy/fmt/link-audit: clean