Draft: Chore/move logic out of nunjucks#162
Conversation
chore: added historyHtml presenter to int test chore: forgot to save
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { text: "Remove" } | ||
| ], | ||
| rows: sharingVM.ownerRows | ||
| }) }} |
There was a problem hiding this comment.
I get an error in the console when trying to share the prototype with another user, and it won't let me add them. Does sharingVM.ownerRows include the hidden user and "Not shared with any users" row?
Uncaught (in promise) TypeError: Cannot read properties of null (reading 'cloneNode')
at HTMLInputElement.<anonymous> (prototype-sharing.js:176:17)
| ], | ||
| rows: sharingVM.ownerRows | ||
| }) }} | ||
|
|
There was a problem hiding this comment.
There should be <p class="sharing-last-updated govuk-body"></p> here, to show the user that the sharing settings are updated when they click save.
| "git.branchProtection": ["main"] | ||
| "git.branchProtection": ["main"], | ||
| "[nunjucks]": { | ||
| "editor.defaultFormatter": "okitavera.vscode-nunjucks-formatter" |
There was a problem hiding this comment.
Can you add this to extensions.json please?
| <ol> | ||
| {% for item in structureVM.list %} | ||
| <li> | ||
| <strong>{{ item.answerType }}</strong>: {{ item.questionText }} |
There was a problem hiding this comment.
I think this was previously wrapped in <a> tags, that when clicked jumped the preview to the question - can you re-add this?
There was a problem hiding this comment.
This page looks to be missing its title and some of the filters; the filters should also be full-width.
| </div> | ||
| </div> | ||
|
|
||
| {{ govukTable({ head: header, rows: prototypeRows }) }} |
There was a problem hiding this comment.
Can we add firstCellIsHeader: true back into this?
3 participants
Description
Currently moved logic out or
results.njkandhistory.njkinto its separate presenter.ts files. Also refactored results.njk to be more in parts for easier access for future development. Looking for feedback on changes so far since the size of change seems more than expected.edit: It has been decided that the logic transfer so far is a good size for this PR.
Related issues: Move logic out of the Nunjucks Views
Checklist before marking as ready for review
Before marking as ready for review, please check that you have:
Check the contributing guidelines for more details.
Screenshots (if appropriate)