-
Notifications
You must be signed in to change notification settings - Fork 2
Bb2 4376 v3 changes #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dd19006
need to remove code_challenge
bwang-icf 285d4cd
intermediary commit
bwang-icf 2bb36b2
change for local dev
bwang-icf 1df1e3c
reverting change from local dev
bwang-icf e0c0430
removing local clutter
bwang-icf 9483d3a
removing other console.log statements as they were erroring out
bwang-icf de9f3af
Update package.json
bwang-icf 08859ee
adding lock files and local node-sdk to gitignore
bwang-icf eb5d536
Delete yarn.lock
bwang-icf f68fa45
Delete package-lock.json
bwang-icf d0b0deb
Merge branch 'master' into BB2-4376-v3-changes
bwang-icf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,14 +81,18 @@ | |
| // access token can expire, SDK automatically refresh access token when that happens. | ||
| const eobResults = await bb.getExplanationOfBenefitData(authToken); | ||
| authToken = eobResults.token; // in case authToken got refreshed during fhir call | ||
|
|
||
| loggedInUser.authToken = authToken; | ||
|
|
||
| loggedInUser.eobData = eobResults.response?.data; | ||
| } catch (e) { | ||
| } catch (e: any) { | ||
| loggedInUser.eobData = {}; | ||
| process.stdout.write(ERR_QUERY_EOB + '\n'); | ||
| process.stderr.write("Exception: " + String(e) + '\n'); | ||
| if (e.response) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bwang-icf should this block be removed? Just given the checks that were called out below, or are we good to ignore those? |
||
| console.log("Error status:", e.response.status); | ||
| console.log("Error data:", e.response.data); | ||
| } | ||
| } | ||
| } else { | ||
| clearBB2Data(); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but should this be gitignored or removed from this changeset? Was this change only generated because we installed from the local sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that can definitely be removed. This may have been in part because I had been trying to get yarn to work right between this and the SDK