Repository navigation
ci: ignore test files in line gate and raise frontend limit to 500 - #95
CJackHwang wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94578b691b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if is_frontend_file "$file"; then | ||
| limit="$FRONTEND_MAX" | ||
| elif is_entry_file "$file"; then |
There was a problem hiding this comment.
Apply entry/facade limit before frontend limit
This ordering makes every webui/* entry file in is_entry_file use the 500-line frontend cap instead of the intended 120-line entry/facade cap. For example, webui/src/App.jsx now matches is_frontend_file first and never reaches the is_entry_file branch, which weakens the gate for the exact files meant to stay strict and contradicts the documented “Entry/facade limit: 120 lines.”
Useful? React with 👍 / 👎.
Motivation
webui/) requires a more permissive line limit than backend production files.Description
FRONTEND_MAX=500andis_frontend_filetotests/scripts/check-refactor-line-gate.shsowebui/*files use a 500-line threshold.is_test_fileto detect and skip test files (matchestests/,*/tests/*,*/__tests__/*,*_test.go, and common*.test.*patterns) in the gate script.webui/-> frontend limit, entry files -> 120 limit, otherwise backend default 300).plans/refactor-line-gate.mdandplans/refactor-line-gate-targets.txtto state backend 300, frontend 500, and that tests are ignored.Testing
./tests/scripts/check-refactor-line-gate.shand it completed successfully withchecked=130 missing=0 over_limit=0.Codex Task