This repository was archived by the owner on May 13, 2026. It is now read-only.
Repository navigation
Support text-kv function.name/function.arguments fallback and looser name matching - #89
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CJackHwang
marked this pull request as ready for review
March 9, 2026 11:17
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
CJackHwang
added a commit
that referenced
this pull request
Mar 9, 2026
Merge pull request #89 from CJackHwang/codex/review-changes-in-pull-request-#88 Support text-kv `function.name`/`function.arguments` fallback and looser name matching
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
function.name: ...andfunction.arguments: {...}.Description
function.name:andfunction.arguments:blocks and extracts tool calls, implemented asparseTextKVToolCallsin the JS helper andparseTextKVToolCalls/toolcalls_textkv.goin Go.internal/js/helpers/stream-tool-sieve/parse.js/parse_payload.js) and Go (internal/util/toolcalls_parse.go).toolcalls_name_match.go) and route existingresolveAllowedToolNameto use the new loose matching logic to support namespace tail and alphanumeric-only comparisons.docs/toolcall-semantics.md) to list the newText KV fallback parserand rename the markup entry toXML/Markup parser.internal/util/toolcalls_textkv_test.gofor Go and additional JS tests intests/node/stream-tool-sieve.test.jsto cover parsing of text-kv payloads.Testing
internal/util/toolcalls_textkv_test.goviago test ./..., which passed.tests/node/stream-tool-sieve.test.js) via the project's JS test runner (npm testor equivalent), which passed.Codex Task