This repository was archived by the owner on May 13, 2026. It is now read-only.
Repository navigation
fix: parse invoke/tool_call arguments in xml compatibility paths - #86
Merged
CJackHwang merged 1 commit intoMar 8, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
CJackHwang
merged commit Mar 8, 2026
9240f85
into
codex/linear-mention-cja-10-ds2api-go-runtime-js
3 checks passed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
<tool_call>and<invoke>styles because<arguments>/<input>/<argument>blocks were not being parsed into the toolinputmap.inputfor cases that contained JSON or KV-style child tags.Description
internal/util/toolcalls_parse_markup.goto collect argument payloads from XML child tags by decoding<input>,<arguments>,<argument>,<args>, and<params>and merging parsed JSON into theparamsmap inparseSingleXMLToolCall.parseInvokeFunctionCallStyleto fall back to extracting arguments viafindMarkupTagValue+parseMarkupInputorparseMarkupKVObjectwhen<parameter>entries are absent, so<invoke name="...">...</invoke>cases correctly populateinput.Testing
./tests/scripts/check-refactor-line-gate.shwhich passed (no missing/over-limit files)../tests/scripts/run-unit-all.shwhich executed unit tests and the JS compat suite; all tests passed.go test ./internal/util ./internal/compatwhich passed and confirmed the toolcall fixtures are now correct.npm ci --prefix webuiandnpm run build --prefix webui, which completed successfully.Codex Task