Skip to content

Tet remeshing - improve normals computation in smoothing step - #9595

Merged
sloriot merged 2 commits into
CGAL:mainfrom
janetournois:Tet_remeshing-reduce_normals_computation-jtournois
Aug 19, 2026
Merged

Tet remeshing - improve normals computation in smoothing step#9595
sloriot merged 2 commits into
CGAL:mainfrom
janetournois:Tet_remeshing-reduce_normals_computation-jtournois

Conversation

@janetournois

@janetournois janetournois commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary of Changes

Remove a useless while loop, and make sure the normals are always taken in the same direction wrt subdomains.

This PR fixes a bug and speeds up remeshing

Release Management

  • Affected package(s): Tetrahedral_remeshing
  • Issue(s) solved (if any): fixes Avoid degenerate ray #9593
  • License and copyright ownership: unchanged

and make sure the normal is always taken in the same direction
wrt to subdomains ids
@sloriot sloriot linked an issue Aug 5, 2026 that may be closed by this pull request
@janetournois
janetournois marked this pull request as ready for review August 5, 2026 15:53
@janetournois janetournois added this to the 6.2.1 milestone Aug 5, 2026
@sloriot

sloriot commented Aug 19, 2026

Copy link
Copy Markdown
Member

Successfully tested in CGAL-6.3-Ic-58

@sloriot
sloriot merged commit 39e4412 into CGAL:main Aug 19, 2026
9 checks passed
@sloriot
sloriot deleted the Tet_remeshing-reduce_normals_computation-jtournois branch August 19, 2026 14:46
@lrineau

lrineau commented Aug 20, 2026

Copy link
Copy Markdown
Member

This PR is marked for 6.2.1. Was it supposed to be merged into 6.2.x-branch?

@sloriot sloriot modified the milestones: 6.2.1, 6.3-beta Aug 20, 2026
@sloriot

sloriot commented Aug 20, 2026

Copy link
Copy Markdown
Member

Only in main. I changed the target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid degenerate ray

3 participants