add missing visitor calls - #9579
Open
sloriot wants to merge 1 commit into
Open
Conversation
LeoValque
reviewed
Jul 31, 2026
| */ | ||
| template <class PolygonMesh, class NamedParameters = parameters::Default_named_parameters> | ||
| typename boost::graph_traits<PolygonMesh>::halfedge_descriptor | ||
| find_crossing_edge(PolygonMesh& pm, |
Contributor
There was a problem hiding this comment.
Suggested change
| find_crossing_edge(const PolygonMesh& pm, |
| if (triangulate){ | ||
| halfedge_descriptor sh_opp = opposite(sh, pm); | ||
| if(!is_triangle(sh_opp, pm)){ | ||
| visitor.before_subface_created(pm); |
Contributor
There was a problem hiding this comment.
Suggested change
| visitor.before_subface_creations(face(sh_opp, pm), pm); |
| if(!is_triangle(sh_opp, pm)){ | ||
| visitor.before_subface_created(pm); | ||
| halfedge_descriptor newh = CGAL::Euler::split_face(sh_opp, next(next(sh_opp, pm), pm), pm); | ||
| visitor.after_subface_created(face(opposite(newh, pm), pm), pm); |
Contributor
There was a problem hiding this comment.
Suggested change
| visitor.after_subface_creations(pm); |
| boundaries.emplace_back(sh); | ||
| set_halfedge(target(sh, pm), sh, pm); | ||
| visitor.add_retriangulation_edge(sh, pm); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| // The input is assumed to be triangulated |
| put(f2f, f, plane_fd); | ||
| } | ||
| if(triangulate) | ||
| triangulate_face(f, pm, parameters::vertex_point_map(vpm)); |
Contributor
There was a problem hiding this comment.
Suggested change
| triangulate_face(f, pm, parameters::vertex_point_map(vpm)); | |
| triangulate_face(f, pm, parameters::vertex_point_map(vpm).visitor(visitor)); |
Member
Author
There was a problem hiding this comment.
probably requires a wrapper
|
|
||
| // Fill the hole | ||
| if (clip_volume && faces(pm).size()>1){ // If there is only one face, the output is flat does not need to be closed | ||
| face_descriptor f=add_face(pm); |
Contributor
There was a problem hiding this comment.
Creation of a new face here
| } | ||
| return *vertices(pm).begin(); | ||
|
|
||
| } else if(faces(pm).size()==1){ |
Contributor
There was a problem hiding this comment.
2D cases here, but it was wrote for untriangulated case (only one face)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@LeoValque Could you please double check that you aren't missing more?