API proposal for 3D mesh smoothing - #9576
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
You write "API proposal", as for now you propose concepts, and the models are "only" in examples, right? |
|
A first feedback |
While the code and examples are already working, this PR was put mainly before the API freeze. Maybe the wording was confusing and I should have detailed that. I have several examples of implementation of the concept, they are in the PR, but undocumented. I wanted to focus on the concept and the C3t3_smoother that could already be of use in GF applications. Thanks for the feedback, I'll do the corrections. |
|
I think the real question is if we do not want to be similar to the BGL API. |
IMHO for this version, I would target something only working for c3t3 and existing CGAL types which would not block the introduction of something more general in the next version (without breaking the API). |
|
I addressed some of the comment, not all, but it is in progress. Regarding BGL, I can see changing some of the naming convention to match better, but why not match more to Triangulation_3 and C3t3 instead? From my understanding, BGL does not support tetrahedral meshes which is the first focus of my code. Having different "framework" for the different concepts (Volume, surface and curves) could be confusing. |
|
|
||
| /*! | ||
| Returns the number of vertices of given face. std::size_t is optional but will avoid warnings. | ||
| Returns the number of vertices of a face. std::size_t is optional but will avoid warnings. |
There was a problem hiding this comment.
What do you mean with "optional" ? That it may also be int or even void ?
There was a problem hiding this comment.
What would be the "less wordy" way to have a "size_type" instead of std::size_t? Triangulation_3 use its own typedef, but here I would see it as unecessary. Do I just use std::size_t?
(Regarding the backticked, I didn't find another example, it would just be std::size_t ?)
| @@ -0,0 +1,6 @@ | |||
| Manual | |||
There was a problem hiding this comment.
| Manual | |
| Manual | |
| SMDS_3 |
There was a problem hiding this comment.
Right now I am not using anything, but that will change later. I will remove everything here and add back progressively.
|
It would be good to not call your branch "main" but for example "Mesh_smoothing-fprotais" |
|
You should also remove trailing whitespace. In emacs I has a hook when saving the file. vscode can also do it. In case there are tabs in your files, you must also replace with blanks. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9576/r2/Manual/index.html |
Summary of Changes
This PR contains the first version of:
for the proposed 3D mesh smoothing package.
Release Management
TODO