Common - Isolate PFH errors - #1821
Open
DarkBall123 wants to merge 1 commit into
Open
Conversation
DarkBall123
marked this pull request as ready for review
July 12, 2026 11:47
LinkIsGrim
approved these changes
Jul 29, 2026
Contributor
|
Comment saying why it's there would probably be good |
Contributor
|
What if we modify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
used the isNil suggestion from the issue so one broken PFH no longer stops the rest. ScriptError and the stack trace are still reported normally.
tested this with persistent and one-off errors, nested handlers, self-removal, adding and removing handlers during iteration, return values and delayed handlers. later handlers and frame queues kept running after an error, and the largest measured overhead was about 0.16 ms with 500 PFHs.
Fixes #1602