fix(keyboard): force redraw after shortcut opens submenu#2320
Draft
pfefferle wants to merge 1 commit intoBruceDevices:devfrom
Draft
fix(keyboard): force redraw after shortcut opens submenu#2320pfefferle wants to merge 1 commit intoBruceDevices:devfrom
pfefferle wants to merge 1 commit intoBruceDevices:devfrom
Conversation
When a keyboard shortcut (e.g. 'f' for Files) opens a submenu from the main menu, the submenu draws over the screen. On exit, the main menu loop didn't know it needed to redraw, causing ESC to appear broken and navigation to produce font-size overlay glitches. Change checkShortcutPress() to return bool, and force a full redraw when it executed a shortcut command. Closes BruceDevices#2156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ffor Files) opens a submenu from the main menu, the submenu draws over the screen. On exit, the main menu loop didn't know it needed to redraw, causing ESC to appear broken and navigation to produce font-size overlay glitches.checkShortcutPress()to returnbool, and force a full redraw when it executed a shortcut command.Closes #2156
Test plan
fin main menu to open Files via shortcuti,r,b,w)