fix: UI bug fixes and improvements#2283
Open
CloudWaddie wants to merge 1 commit intoBruceDevices:mainfrom
Open
fix: UI bug fixes and improvements#2283CloudWaddie wants to merge 1 commit intoBruceDevices:mainfrom
CloudWaddie wants to merge 1 commit intoBruceDevices:mainfrom
Conversation
- Fix variable shadowing bug in keyStroke::Clear() (globals.h) The alt/ctrl/gui boolean members were being shadowed by local declarations in the Clear() function, preventing them from being properly reset. - Remove duplicate tft.setCursor() call in displayScrollingText() (display.cpp) - Implement text wrapping for toast messages (display.cpp) Added wrapText() helper function and updated displayRedStripe() to support multi-line text with dynamic box height. Also cleaned up displayInfo(), displaySuccess(), and displayTextLine() functions. - Implement validateImgFile() stub (theme.cpp) Added proper validation logic to check file existence and reasonable size (64 bytes min, 500KB max) for theme images. - Add visual polish to menu selection (display.cpp) Added selection highlight bar behind currently selected menu item with inverted colors for better visual feedback.
Author
|
/gemini review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug Fixes
globals.h - Variable shadowing fix
keyStroke::Clear()wherealt,ctrl,guiboolean members were being shadowed by local declarations, preventing them from being properly resetdisplay.cpp - Duplicate cursor removal
tft.setCursor()call indisplayScrollingText()display.cpp - Text wrapping for toast messages
wrapText()helper function for word-boundary aware text wrappingdisplayRedStripe()to support multi-line text with dynamic box heightdisplayInfo(),displaySuccess(), anddisplayTextLine()functionstheme.cpp - validateImgFile() implementation
UI Improvements
Files Changed
include/globals.hsrc/core/display.cppsrc/core/theme.cpp