Skip to content

Use new b2nd_deserialize_meta_inline() in forthcoming c-blosc2 3.1.0#23

Merged
FrancescAlted merged 2 commits into
mainfrom
blosc2-inline
Jun 24, 2026
Merged

Use new b2nd_deserialize_meta_inline() in forthcoming c-blosc2 3.1.0#23
FrancescAlted merged 2 commits into
mainfrom
blosc2-inline

Conversation

@FrancescAlted

Copy link
Copy Markdown
Member

This will allow to compile this plugin without the need to link with libblosc2 at all. But we will need to wait until a new C-Blosc2 release would be out. Addresses #22.

@t20100

t20100 commented Jun 22, 2026

Copy link
Copy Markdown

Hi,

Testing this PR with hdf5plugin tests from silx-kit/hdf5plugin#388, I encountered the following 2 issues:

  • Use of BLOSC2_MAX_DIM:

    -    int64_t shape[BLOSC2_MAX_DIM];
    -    int32_t chunkshape[BLOSC2_MAX_DIM];
    -    int32_t blockshape[BLOSC2_MAX_DIM];
    +    int64_t shape[B2ND_MAX_DIM];
    +    int32_t chunkshape[B2ND_MAX_DIM];
    +    int32_t blockshape[B2ND_MAX_DIM];
  • Linking error for error messages:

    OSError: /home/tvincent/miniforge3/envs/py314/lib/python3.14/site-packages/blosc2_grok/libblosc2_grok.so: undefined symbol: blosc2_error_string
    

    Removing BLOSC_ERROR macros from blosc2_grok fixes the issue. Having BLOSC_ERROR relying on header only definitions is maybe a better fix.

@FrancescAlted

Copy link
Copy Markdown
Member Author

Hi,

Testing this PR with hdf5plugin tests from silx-kit/hdf5plugin#388, I encountered the following 2 issues:

  • Use of BLOSC2_MAX_DIM:

    -    int64_t shape[BLOSC2_MAX_DIM];
    -    int32_t chunkshape[BLOSC2_MAX_DIM];
    -    int32_t blockshape[BLOSC2_MAX_DIM];
    +    int64_t shape[B2ND_MAX_DIM];
    +    int32_t chunkshape[B2ND_MAX_DIM];
    +    int32_t blockshape[B2ND_MAX_DIM];
  • Linking error for error messages:

    OSError: /home/tvincent/miniforge3/envs/py314/lib/python3.14/site-packages/blosc2_grok/libblosc2_grok.so: undefined symbol: blosc2_error_string
    

    Removing BLOSC_ERROR macros from blosc2_grok fixes the issue. Having BLOSC_ERROR relying on header only definitions is maybe a better fix.

Good remarks. Both fixed in 41ef2b9.

@FrancescAlted FrancescAlted merged commit a63563f into main Jun 24, 2026
7 checks passed
@FrancescAlted FrancescAlted deleted the blosc2-inline branch June 24, 2026 09:50
@FrancescAlted

Copy link
Copy Markdown
Member Author

Merged, as c-blosc2 3.1.0 is out for a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants