Fix BL-16538 Little arrow in Leveled Reader Tool displays after reenable tool on Canvas page#8077
Open
andrew-polk wants to merge 1 commit into
Open
Fix BL-16538 Little arrow in Leveled Reader Tool displays after reenable tool on Canvas page#8077andrew-polk wants to merge 1 commit into
andrew-polk wants to merge 1 commit into
Conversation
…ble tool on Canvas page https://issues.bloomlibrary.org/youtrack/issue/BL-16538 The Leveled/Decodable Reader tool bodies are adopted out of the hidden legacy jQuery-UI accordion (#toolbox) and moved into the React/MUI accordion. Those body divs still carry the jQuery-UI ui-accordion-header class, so jQuery-UI's _createIcons() prepends a span.ui-accordion-header-icon (a ui-icon-triangle-1-e sprite) to them. Positioned absolute at the top-left, it renders as a stray right-pointing arrowhead in the tool body. accordion("refresh") on re-enable re-runs _createIcons, which is why it appears intermittently after re-enabling a reader tool on a Canvas page. The earlier BL-16501 fix neutralized these divs' header background/border theming but did not hide the prepended icon span. This adds a rule to the same CSS block hiding span.ui-accordion-header-icon on adopted div[data-toolid] bodies. Tests: none added (CSS-only fix; ran prettier and eslint on the changed file, both clean). Not verified live in Bloom (intermittent repro). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
| Filename | Overview |
|---|---|
| src/BloomBrowserUI/bookEdit/toolbox/ToolboxRoot.tsx | Adds a CSS rule to hide the stray jQuery-UI accordion header icon (span.ui-accordion-header-icon) that jQuery-UI's _createIcons() prepends to adopted reader-tool body div[data-toolid] elements, fixing the intermittent right-pointing arrowhead artifact (BL-16538). |
Reviews (1): Last reviewed commit: "Fix BL-16538 Little arrow in Leveled Rea..." | Re-trigger Greptile
Contributor
Author
|
[Claude Opus 4.8] Consulted Devin on 2026-07-17 18:40 UTC up to commit |
andrew-polk
marked this pull request as ready for review
July 17, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the stray right-pointing arrowhead (►) that intermittently appears in the top-left of the Leveled/Decodable Reader tool body after re-enabling the tool via "More…" on a Canvas page.
Root cause
The toolbox is mid-migration: a hidden legacy jQuery-UI accordion (
#toolbox,display:none) runs alongside the visible React/MUI accordion (ToolboxRoot.tsx). The Leveled/Decodable Reader tool bodydivs are adopted out of the legacy accordion into React, but still carry the jQuery-UIui-accordion-headerclass. jQuery-UI's_createIcons()prepends aspan.ui-accordion-header-icon(aui-icon-triangle-1-eright-triangle sprite, positionedabsolute; left:.5em; top:50%) to anything with that class — so it renders as the stray arrowhead.accordion("refresh")on re-enable re-runs_createIcons, which is why it's intermittent after re-enabling a reader tool.The earlier BL-16501 fix neutralized these divs' header background/border theming but did not hide the prepended icon span. This adds a rule to the same CSS block hiding
span.ui-accordion-header-iconon adopteddiv[data-toolid]bodies.Change
CSS-only, in the emotion
cssblock wrapping the adopted reader body inToolboxRoot.tsx.Ref: https://issues.bloomlibrary.org/youtrack/issue/BL-16538
Devin review
This change is