Skip to content

Integrate restyled Image Chooser (bloom-image-gallery)#8059

Draft
hatton wants to merge 1 commit into
masterfrom
image-chooser-restyle
Draft

Integrate restyled Image Chooser (bloom-image-gallery)#8059
hatton wants to merge 1 commit into
masterfrom
image-chooser-restyle

Conversation

@hatton

@hatton hatton commented Jul 13, 2026

Copy link
Copy Markdown
Member

Bumps the bloom-image-gallery dependency to the restyled Image Chooser and adds the localizable strings its detail pane needs.

bloom-image-gallery side: PR #18 — justified-rows grid, sidebar pills, structured attribution, plus review follow-ups (stale local-file image cleared on provider-clear; SearchBar lint tidy). This BloomDesktop PR pins that repo at 0b4ae4e.

Changes here (integration only):

  • package.json / pnpm-lock.yaml: bloom-image-gallery0b4ae4e. The lock change is a minimal in-place hash+integrity swap, keeping the repo's existing lockfile serialization format (a full pnpm install reformats the whole lock because the committed lock predates the local pnpm's serialization style — out of scope for this PR).
  • BloomMediumPriority.xlf: adds ImageLibrary.SelectImagePrompt, ImageLibrary.Dimensions, ImageLibrary.FileSize, ImageLibrary.License.

🤖 Generated with Claude Code

Devin review


This change is Reviewable

Bump the bloom-image-gallery dependency to the restyled Image Chooser
(justified-rows grid, sidebar pills, structured attribution) and add the
new localizable strings its detail pane needs.

- package.json / pnpm-lock.yaml: bloom-image-gallery -> 0b4ae4e (the
  restyle plus its review follow-ups: stale local-file image cleared on
  provider-clear, SearchBar lint tidy). The lock change is a minimal,
  in-place hash+integrity swap to keep it in the repo's existing
  lockfile format.
- BloomMediumPriority.xlf: add ImageLibrary.SelectImagePrompt,
  ImageLibrary.Dimensions, ImageLibrary.FileSize, ImageLibrary.License.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps bloom-image-gallery to a specific commit (0b4ae4e) and adds four localizable strings for the Image Chooser detail pane. The dependency pin and XLF additions are straightforward, but the lockfile update is incomplete.

  • package.json correctly pins the package to github:BloomBooks/bloom-image-gallery#0b4ae4e..., but the specifier field in pnpm-lock.yaml was not updated to match, leaving it as github:BloomBooks/bloom-image-gallery with no commit suffix.
  • BloomMediumPriority.xlf gains four new ImageLibrary.* trans-units (SelectImagePrompt, Dimensions, FileSize, License), all consistent with the file's existing translate=\"no\" convention and note format.

Important Files Changed

Filename Overview
src/BloomBrowserUI/package.json Pins bloom-image-gallery to a specific commit hash (0b4ae4e) instead of tracking the default branch; change itself is correct.
src/BloomBrowserUI/pnpm-lock.yaml Tarball URL and integrity hash updated to the new commit, but the specifier field under importers still says github:BloomBooks/bloom-image-gallery without the commit suffix, mismatching package.json — this will break frozen-lockfile installs.
DistFiles/localization/en/BloomMediumPriority.xlf Adds four new ImageLibrary trans-unit strings (SelectImagePrompt, Dimensions, FileSize, License) consistent with the file's existing format and translate="no" convention.

Reviews (1): Last reviewed commit: "Integrate restyled Image Chooser (bloom-..." | Re-trigger Greptile

Comment on lines 88 to +89
specifier: github:BloomBooks/bloom-image-gallery
version: https://codeload.github.com/BloomBooks/bloom-image-gallery/tar.gz/51c5a75bb611c51dd24b40c9162929c6e75473eb(@types/react@18.3.31)(supports-color@5.5.0)
version: https://codeload.github.com/BloomBooks/bloom-image-gallery/tar.gz/0b4ae4e253d7d5b93f089f43f9a7752452c1cf9a(@types/react@18.3.31)(supports-color@5.5.0)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Lock-file specifier out of sync with package.json

package.json now pins bloom-image-gallery to github:BloomBooks/bloom-image-gallery#0b4ae4e253d7d5b93f089f43f9a7752452c1cf9a, but the specifier field in the lockfile still reads github:BloomBooks/bloom-image-gallery (no commit). pnpm's lockfile validator compares the specifier verbatim against package.json; a mismatch causes pnpm install --frozen-lockfile to error out (lockfile outdated). If CI runs without --frozen-lockfile, pnpm will silently re-resolve the package and may pull the current default-branch HEAD instead of the intended commit.

@hatton

hatton commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

[Claude Opus 4.8] Consulted Devin on 2026-07-13 23:36 UTC up to commit 36feaf5. Result: 0 Bugs, 0 Investigate flags — re-review clean. (Triggered automatically via pr-automation.yml on push; findings read from the Devin review page.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant