Fix/chipsec - #4
Merged
Merged
Conversation
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the chipsec package and refactors the NixOS module structure to simplify the build system and improve maintainability.
Key Changes
- Chipsec package update: Upgraded from version 1.10.6 to 1.13.17, switching to
pyproject = truebuild system and usingtaginstead ofrevfor fetching sources - Module consolidation: Merged functionality from
modules/default-tools.nixintomodules/base.nix, removing the need for a separate file and usinglib.mkMergefor cleaner configuration - Simplified build targets: Removed the separate
chipsecconfiguration/image, consolidating into a singlebaseimage with an optionalincludeChipSecflag (now defaulting totrue)
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkgs/chipsec/default.nix | Updated chipsec to version 1.13.17, switched to pyproject build system, simplified driver build logic with marker file approach |
| pkgs/chipsec/log-path.diff | Added new patch to set log path to /tmp/chipsec instead of relative path |
| pkgs/chipsec/ko-path.diff | Removed obsolete kernel module path patch (no longer needed with new build approach) |
| pkgs/chipsec/compile-ko.diff | Removed obsolete driver compilation patch (replaced by marker file approach) |
| modules/kernel.nix | Updated default kernel to 6.12.58, added includeIntelModules option for conditional Intel module loading, improved option descriptions |
| modules/base.nix | Consolidated default-tools functionality, refactored using lib.mkMerge for cleaner conditional configuration, changed includeChipSec default to true |
| modules/default-tools.nix | Removed file (functionality merged into base.nix) |
| flake.nix | Renamed modules to nixosModules, removed separate chipsec configuration, updated to use packages.default instead of deprecated defaultPackage |
| README.md | Updated documentation to reflect single base image approach, updated kernel version info, clarified chipsec compatibility requirements |
| Makefile | Removed chipsec target, keeping only base target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
llogen
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.