Feat/amd debug - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds AMD debugging capabilities to the firmware CI base image by introducing new packages and a configuration option.
- Adds two new package definitions:
s0ix-selftest-tool(Intel S0ix testing tool) andamd-debug-tools(AMD firmware debugging utilities) - Updates chipsec from version 1.10.6 to 1.12.0
- Introduces a new
firmwareci.amdDebug.enableoption to conditionally include AMD debug tools, ethtool, and edid-decode
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkgs/s0ix-selftest-tool/default.nix | New package for Intel's S0ix self-test tool with runtime dependencies wrapped via makeWrapper |
| pkgs/amd-debug-tools/default.nix | New Python package for AMD debug tools with dynamic versioning patched to static version |
| pkgs/chipsec/default.nix | Version bump from 1.10.6 to 1.12.0 with updated source hash |
| modules/base.nix | Adds amdDebug configuration option, integrates new packages, and enables D-Bus when AMD debug tools are enabled |
| flake.nix | Enables amdDebug for demonstration configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
RiSKeD
force-pushed
the
feat/amd-debug
branch
from
November 17, 2025 08:23
ebea686 to
453fa77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.