Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Hardcover search does not reliably surface Korean translations when EPUB metadata contains localized titles, contributor roles, or no usable ISBN. PR #64 adds conservative Korean metadata normalization and similarity checks; this stacked draft builds on that work by using Aladin as an optional Korean discovery source.
The reading service remains Hardcover. Aladin is used only to discover Korean editions and their ISBNs.
Changes
Aladin TTB keyfield under the Hardcover settings menu, withhardcover_config.luafallback supportThis intentionally does not create public Hardcover books or editions automatically. An Aladin result is linkable only when its exact ISBN already exists in Hardcover, avoiding duplicate works and incorrect translation-to-work associations.
Validation
busted: 64 successes, 0 failuresluac -p: all Lua files passed이기적 유전자/리처드 도킨스, which has no ISBN:9788932421278resolves to Hardcover edition331265609788932473901resolves to Hardcover edition33126561이기적 유전자instead of the work-level titleThe Selfish Gene만들어진 신by Richard Dawkins / 이한음:978893497263133126542The God Delusion(382874)소년이 온다,채식주의자,작별하지 않는다,아몬드, and불편한 편의점Risks / review notes