Ada 233

[yzhoubk]

ADA-233: Ensure landmarks are unique

[awilfox]

I don't think this is exactly correct.

• Firstly, screen readers typically announce the role, so the NAV element would announce as "Main navigation navigation".
• However, I don't think an aria-label should be needed on the NAV, because it should be the only element with a navigation role. The search bar does not serve a navigation role; if anything it serves a search role. The Blacklight search form has the search role defined on it correctly, so I do not think we should be setting the role on this element.

I think the best, and simplest, way forward is to simply remove the role="navigation" from the search bar's containing DIV. No other changes should be needed as far as I can tell. Tagging @jxloesberg for his input.

[jxloesberg]

I agree with @awilfox. <nav> is sufficient here, and so the role attribute redundant, and generates confusion. I also recommend simply removing it. No other changes are required.

[yzhoubk]

Thanks for the suggestions!