Conversation
I pinned the Arm64 version of Rollup to the same version as the x64 versions, and ensured it is optional like the x64 versions as well. With this change, the container now builds and runs on Arm64. Closes: AP-344
Member
Author
|
After discussing this on Slack, we have decided to replace Rollup with the WASM version. This allows for further build types and architectures to be accounted for (musl, other CPUs), and provides future proofing. I will open a PR for that instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pinned the Arm64 version of Rollup to the same version as the x64 versions, and ensured it is optional like the x64 versions as well. With this change, the container now builds and runs on Arm64.
Closes: AP-344