AP 581 - refactor stubs and job fixtures#9
Conversation
davezuckerman
left a comment
There was a problem hiding this comment.
Some general comments. docker-compose.yml should probably have a test service added so tests can be running locally via the container or at least have a comment in the read me of how to run locally. e.g. docker compose run --rm --entrypoint /bin/sh app -lc "bundle exec rubocop" but probably better to have a test service.
also, I see when running it that it's getting a lot of API failures. Is it trying to make actual API calls?
|
Per DZ's suggestion, I've added a local docker compose file for running tests (or rubocop) via docker compose. Re the "API failures", those are by design. It's testing out functionality that handles failed API calls and no, it does not make any actual API calls. Any unstubbed http request will throw an error. |
No description provided.