Skip to content

AP 581 - refactor stubs and job fixtures#9

Merged
steve-sullivan merged 5 commits intomainfrom
AP-581-fixtures
Mar 20, 2026
Merged

AP 581 - refactor stubs and job fixtures#9
steve-sullivan merged 5 commits intomainfrom
AP-581-fixtures

Conversation

@steve-sullivan
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@davezuckerman davezuckerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments. docker-compose.yml should probably have a test service added so tests can be running locally via the container or at least have a comment in the read me of how to run locally. e.g. docker compose run --rm --entrypoint /bin/sh app -lc "bundle exec rubocop" but probably better to have a test service.

also, I see when running it that it's getting a lot of API failures. Is it trying to make actual API calls?

@steve-sullivan
Copy link
Copy Markdown
Contributor Author

Per DZ's suggestion, I've added a local docker compose file for running tests (or rubocop) via docker compose.

Re the "API failures", those are by design. It's testing out functionality that handles failed API calls and no, it does not make any actual API calls. Any unstubbed http request will throw an error.

@steve-sullivan steve-sullivan merged commit 0032a1a into main Mar 20, 2026
5 checks passed
@steve-sullivan steve-sullivan deleted the AP-581-fixtures branch March 20, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants