ci: Fix deprecated client-id param in update job actions - #438
Merged
Merged
Conversation
Our cucumber-update job uses the create-github-app-token action to create a GitHub token to commit with so that it triggers CI. create-github-app-token deprecated the `client-id` input in favour of `app-id` in their [3.1.0 release back in April](https://github .com/actions/create-github-app-token/releases/tag/v3.1.0) However we did not detect this until [reviewdog/actionlint v1.75.0](https://github.com/reviewdog/action-actionlint/releases/tag/v1.75.0) was released this morning, because they have just switched to a newer fork of actionlint that detects a wider range of issues including deprecated inputs. Hence CI was fine yesterday, but broke when I merged this morning. I have switched over to the new `client-id` input and provisioned the client ID in the repository settings. As per https://github.blog/changelog/2024-05-01-github-apps-can-now-use-the-client-id-to-fetch-installation-tokens/ the client ID is not a secret & is expected to be visible to end users.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
=========================================
Coverage 95.76% 95.76%
Complexity 697 697
=========================================
Files 46 46
Lines 2080 2080
=========================================
Hits 1992 1992
Misses 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
stof
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our cucumber-update job uses the create-github-app-token action to create a GitHub token to commit with so that it triggers CI.
create-github-app-token deprecated the
client-idinput in favour ofapp-idin their 3.1.0 release back in April.However we did not detect this until reviewdog/actionlint v1.75.0 was released this morning, because they have just switched to a newer fork of actionlint that detects a wider range of issues including deprecated inputs.
Hence CI was fine yesterday, but broke when I merged this morning.
I have switched over to the new
client-idinput and provisioned the client ID in the repository settings.As per https://github.blog/changelog/2024-05-01-github-apps-can-now-use-the-client-id-to-fetch-installation-tokens/ the client ID is not a secret & is expected to be visible to end users.