Fix/eventcount#196
Open
juneymf wants to merge 8 commits into
Open
Conversation
Collaborator
|
Hi June -- In terms of a fix for your issue, the diff looks fine to me. But I think this is a good example of why UserDefinedPhenotype shouldn't exist. It breaks the programming API. The check for return_date='all' is for the user's safety and to ensure the code is doing what it's supposed to do. Removing it and allowing people to have "untyped" UserDefinedPhenotype's means people can potentially use EventCountPhenotype incorrectly. In my opinion, implementing a UserDefinedPhenotype is exactly as hard as subclassing Phenotype, except that the latter is consistent with the Phenex API and brings the user all the benefits and safety checks that come with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added escape for userdefinedphenotype in eventcountphenotype