Repository navigation
Fix DynFuncCall argument type check and StructFilter context setting - #2549
Merged
Merged
Conversation
Member
|
Thanks. I will adopt your solution unchanged. The filter for structs may be optimized later on if it remains in the language. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2546 was caused by the change made for #2530. While the change is doing the right thing, its check for the function being a map is insufficient. It checked for
instanceof XQMap, but should have checked.seqType().type instanceof MapType, in order to also cover variables, as in the first offending query.The other query (from #2547) calls for an additional fix. Its empty result is caused by
MapCompilationanalysingkeyMismatchfor a map type ofmap(xs:integer, xs:integer)and a key type ofxs:string. However the relevant map type in this case would have beenrecord(key as xs:anyAtomicType, value as item()*). The map type originates from the context setting established inAFilter.inline, and I have set it tonullfor theStructFiltercase. Maybe there is a better solution for this one?