VAPI-3239 fix: wait for init() before handling a subscribe SDP offer#10
Closed
smoghe-bw wants to merge 1 commit into
Closed
VAPI-3239 fix: wait for init() before handling a subscribe SDP offer#10smoghe-bw wants to merge 1 commit into
smoghe-bw wants to merge 1 commit into
Conversation
The "ready" and "init" signaling events aren't sequenced against each other, so a subscribe SDP offer can arrive and be dispatched to handleSubscribeSdpOffer before init() finishes creating subscribingPeerConnection. This previously threw "No subscribing RTCPeerConnection, cannot handle SDP offer" and silently dropped the offer, leaving that leg without subscribed media. handleSubscribeSdpOffer now waits on a readiness promise that init() resolves once subscribingPeerConnection exists, bounded by a timeout so a connection that never initializes doesn't hang the subscribe mutex forever.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "ready" and "init" signaling events aren't sequenced against each other, so a subscribe SDP offer can arrive and be dispatched to handleSubscribeSdpOffer before init() finishes creating subscribingPeerConnection. This previously threw "No subscribing RTCPeerConnection, cannot handle SDP offer" and silently dropped the offer, leaving that leg without subscribed media.
handleSubscribeSdpOffer now waits on a readiness promise that init() resolves once subscribingPeerConnection exists, bounded by a timeout so a connection that never initializes doesn't hang the subscribe mutex forever.