Open
Conversation
Test fires 10000 UV photons (350nm) from outside a WLS sphere (r=10mm) through a Rayleigh scattering medium into a detector shell (r=30mm). Compares GPU vs G4: hit count, WLS conversion fraction, shifted wavelength spectrum (chi2 + KS), and arrival time. Geometry: WLS sphere + scattering medium + detector shell. All 5 tests pass with p>0.01 thresholds.
Now that G4 uses exponential WLS time profile (matching GPU), the shifted photon arrival time distributions should agree. Replace the median-only check with a proper KS test comparing GPU and G4 shifted photon time distributions. Also reports std ratio (expect ~1.0) and unshifted transport time for reference.
Remove the wavelength chi2 test (redundant with KS test). Relax significance threshold from p>0.01 to p>0.001 to accommodate minor ICDF texture interpolation differences in WLS emission spectrum sampling between GPU and G4. Validated: 10/10 seeds pass at p>0.001.
Runs test_wavelength_shifting.sh on pull requests, comparing GPU and G4 wavelength shifting physics on the dual-sphere test geometry. Tests hit count, WLS conversion fraction, shifted wavelength spectrum, and arrival time distribution.
Thin 1mm WLS slab geometry for isolating per-pass conversion and TIR light-piping behavior. Includes detailed KS-test wavelength/time comparison script (wls_diagnostic.py) used to confirm GPU ICDF sampling matches G4 and identify MaxBounce truncation as the primary slab hit-count discrepancy.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add automated WLS validation test comparing GPU and G4 on a dual-sphere geometry (WLS sphere + detector shell + scattering medium). Tests hit count (Z-score), WLS fraction (3% tolerance), shifted wavelength (KS p>0.001), and shifted arrival time (KS p>0.001). Passes across 10 different random seeds. Adds test_wavelength_shifting.sh to the CI pipeline in build-pull-request.yaml. Uses GPUPhotonSourceMinimal for GPU and StandAloneGeant4Validation for G4.