Skip to content

ci: expand image build matrix and align PR, push, and release workflows#244

Merged
plexoos merged 5 commits intomainfrom
pr/update-workflow-matrix
Apr 11, 2026
Merged

ci: expand image build matrix and align PR, push, and release workflows#244
plexoos merged 5 commits intomainfrom
pr/update-workflow-matrix

Conversation

@plexoos
Copy link
Copy Markdown
Member

@plexoos plexoos commented Mar 25, 2026

This PR updates the container build workflows to use explicit build variants instead of relying on default Docker build arguments, and aligns image tagging across PR, push, and release jobs.

Why

Previously, the PR workflow only varied target, so builds implicitly depended on Dockerfile defaults for OS, CUDA, and OptiX. This change makes the tested and published build variants explicit, improves tag clarity, and keeps the PR smoke and test jobs aligned with the supported image combinations.

Notes

  • PR release smoke now runs the same variant set as develop test, but on GitHub-hosted Ubuntu since it only builds and does not require GPU execution
  • develop test image tags now include Geant4 so each tested variant is uniquely identified

Copilot AI review requested due to automatic review settings March 25, 2026 23:38
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b53e931a83

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the container build GitHub Actions workflows to make build variants (OS/CUDA/OptiX/Geant4) explicit in PR testing and to standardize image tag structure across PR, branch-push, and release builds.

Changes:

  • Expand the PR workflow into explicit build matrices for a release “smoke build” and develop “build+test” across multiple OS/CUDA/OptiX/Geant4 combinations.
  • Update push/release tagging to include CUDA/OS/OptiX details and add CUDA-major short tags; add a devel alias for the default CUDA major on pushes.
  • Simplify the release workflow by removing explicit Geant4/CMake matrix/build-args (falling back to Dockerfile defaults).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/build-pull-request.yaml Adds explicit build variants, a release smoke build, and develop tests with variant-specific tags and caching.
.github/workflows/build-push.yaml Switches from target-based tags to variant tags + CUDA-major short tags; adds devel alias tagging.
.github/workflows/release.yaml Aligns release tags with the new variant-based scheme and removes Geant4/CMake build-args from the release job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

@plexoos I've opened a new pull request, #246, to work on those changes. Once the pull request is ready, I'll request review from you.

@plexoos plexoos force-pushed the pr/update-workflow-matrix branch 5 times, most recently from a2baeaf to ec4058d Compare March 31, 2026 14:12
@plexoos plexoos force-pushed the pr/update-workflow-matrix branch 2 times, most recently from be9c31c to 7dc55a8 Compare April 7, 2026 22:47
@plexoos
Copy link
Copy Markdown
Member Author

plexoos commented Apr 7, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7dc55a85ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@plexoos plexoos force-pushed the pr/update-workflow-matrix branch 3 times, most recently from 3659fd7 to a0d525a Compare April 9, 2026 21:14
@plexoos
Copy link
Copy Markdown
Member Author

plexoos commented Apr 9, 2026

@codex review again

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0d525ac5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@plexoos plexoos self-assigned this Apr 9, 2026
@plexoos plexoos added enhancement New feature or request labels Apr 9, 2026
@plexoos plexoos added this to simphony Apr 9, 2026
@github-project-automation github-project-automation bot moved this to Backlog in simphony Apr 9, 2026
@plexoos plexoos added this to the 1.0.0 milestone Apr 9, 2026
@plexoos plexoos force-pushed the pr/update-workflow-matrix branch from 3f90148 to 6b5202d Compare April 10, 2026 15:16
@plexoos plexoos force-pushed the pr/update-workflow-matrix branch from 6b5202d to b07bc74 Compare April 10, 2026 20:31
@plexoos plexoos force-pushed the pr/update-workflow-matrix branch from 71302d1 to c7bec0a Compare April 11, 2026 00:14
@plexoos plexoos merged commit 2e02e3f into main Apr 11, 2026
20 checks passed
@plexoos plexoos deleted the pr/update-workflow-matrix branch April 11, 2026 00:24
@github-project-automation github-project-automation bot moved this from Backlog to Done in simphony Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants