ci: expand image build matrix and align PR, push, and release workflows#244
ci: expand image build matrix and align PR, push, and release workflows#244
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b53e931a83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates the container build GitHub Actions workflows to make build variants (OS/CUDA/OptiX/Geant4) explicit in PR testing and to standardize image tag structure across PR, branch-push, and release builds.
Changes:
- Expand the PR workflow into explicit build matrices for a release “smoke build” and develop “build+test” across multiple OS/CUDA/OptiX/Geant4 combinations.
- Update push/release tagging to include CUDA/OS/OptiX details and add CUDA-major short tags; add a
develalias for the default CUDA major on pushes. - Simplify the release workflow by removing explicit Geant4/CMake matrix/build-args (falling back to Dockerfile defaults).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/build-pull-request.yaml | Adds explicit build variants, a release smoke build, and develop tests with variant-specific tags and caching. |
| .github/workflows/build-push.yaml | Switches from target-based tags to variant tags + CUDA-major short tags; adds devel alias tagging. |
| .github/workflows/release.yaml | Aligns release tags with the new variant-based scheme and removes Geant4/CMake build-args from the release job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a2baeaf to
ec4058d
Compare
be9c31c to
7dc55a8
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7dc55a85ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3659fd7 to
a0d525a
Compare
|
@codex review again |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0d525ac5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3f90148 to
6b5202d
Compare
6b5202d to
b07bc74
Compare
71302d1 to
c7bec0a
Compare
This PR updates the container build workflows to use explicit build variants instead of relying on default Docker build arguments, and aligns image tagging across PR, push, and release jobs.
Why
Previously, the PR workflow only varied
target, so builds implicitly depended on Dockerfile defaults for OS, CUDA, and OptiX. This change makes the tested and published build variants explicit, improves tag clarity, and keeps the PR smoke and test jobs aligned with the supported image combinations.Notes