Repository navigation
sglang-explainer-video: one cover design per video, ending links to source and cookbook - #148
Merged
Merged
Conversation
…ource and cookbook - Cover: every video gets its own design, derived from its content and checked against the recent covers (cover_kit.py wall, references/cover-log.md). The brand-orange template stays for videos whose user asks for the series look. cover_kit.py writes the animated frame 1 and both stills from a project's css() / body() / reveal steps. - Ending: the last frame now carries a links card above the follow strip, with the source the video explains and the cookbook or docs page to open next. check_frames.mjs requires it; check_links.py opens every link shown. - Publishing: titles and descriptions are written from each video's own hook and close with the same links; publish_check.py checks for them. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two pieces of feedback on the latest explainer videos:
What changes
Cover: one design per video
house-style.md§Cover: design from the content, differ from each of the last five covers in at least three of ground / accent / type / composition / illustration, keep the hook as the largest line and the smallSGLang PR 讲解 · #Ntag.scripts/cover_kit.py: turns a project'scss(width, dy),body(prefix)and reveal steps into the animated frame 1 and both stills;cover_kit.py walltiles the newest covers so a new design can be compared with them.references/cover-log.md: what each cover so far used.make_cover.pytemplate stays for a video whose user asks for the series look.Ending links
assets/brand/follow-strip.html, both themes) gains a links card above the follow strip: the source the video explains, and the cookbook or docs page to open next.check_frames.mjsrequires the card with one link of each kind;check_links.pyopens every link on the last frame and in the publish texts.Titles and descriptions
publishing.md§Title and description: written from each video's hook, no fixed prefix, shaped by the story, closing with the same links as the last frame.publish_check.pyfails an SGLang text without the source and cookbook / docs links.Validation
pytest tests/test_explainer_*.py: 55 passed (new: cover kit, link extraction, link checks in publish texts).pre-commit runon the changed files: all hooks pass.cover_kit.py, last frames carry the links card,check_frames.mjspasses on both and fails an older project without the card, andcheck_links.pyopened all six links of each video.🤖 Generated with Claude Code