Repository navigation
sglang-explainer-video: approve fastokens, rewords from the PR 49570 / 48928 videos - #146
Merged
Merged
Conversation
…/ 48928 videos Pronunciation findings from the PR 49570 and PR 48928 explainer videos (2026-11-14, zh-CN-XiaoxiaoNeural): - fastokens is read "fast tokens", the reading meant; pron_check fails only because Whisper writes the doubled t. Add it to `approved` and pin it in the tests. - config, thinking, segments and PIL had no passing respelling; the narration was reworded and the terms stay on screen. - Six seg_check cuts and two line_asr mishearings, each fixed by a reword. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pronunciation findings from two short explainer videos (SGLang PR 49570, the bright-image edit fix, and PR 48928, segmented fastokens for DeepSeek recipe prompts), measured 2026-11-14 on zh-CN-XiaoxiaoNeural with edge-tts and mlx-whisper. Both takes went through
pron_check.py --asr,seg_check.py,line_asr.py,hang_take.pyandtone_take.py.Lexicon (
pronunciation.json)fastokensjoinsapproved. The voice reads it "fast tokens", which is the reading meant;pron_checkreported FAIL only because Whisper writes "Fast Tokens" with a doubled t. A respelling to "fast tokens" failed the same string compare, so it is approved as written and pinned intests/test_explainer_pronounce.py.references/pronunciation.mdrecordsChecks
pytest tests/test_explainer_pronounce.py tests/test_explainer_seg_check.py tests/test_explainer_publish_check.py tests/test_explainer_tone_take.py: 47 passed before trimming the new test to one assertion;tests/test_explainer_pronounce.pyalone: 35 passed.pre-commit run --fileson the three changed files passes.🤖 Generated with Claude Code