Skip to content

Fix localized Copilot replacement URLs - #91

Merged
Sajeetharan (sajeetharan) merged 2 commits into
mainfrom
fix/canonicalize-copilot-related-urls
Sep 24, 2026
Merged

Sajeetharan (sajeetharan) merged 2 commits into
mainfrom
fix/canonicalize-copilot-related-urls

Conversation

@jaydestro

@jaydestro Jay Gordon (jaydestro) commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • canonicalize Copilot-provided relatedUrl values before promotion
  • strip Microsoft Learn locale prefixes using the existing URL normalizer
  • add workflow-level regression coverage for the exact /en-us/azure/documentdb/... responses from the failed run

Root cause

Workflow run 35905609027 classified two Cosmos DB for MongoDB vCore entries for retirement and returned localized replacement URLs. Classification accepted them, but catalog validation later rejected localized Microsoft documentation URLs and aborted promotion.

Workflow requirements validated

The regression passes both failed URLs through classification, promotion, and proposal rendering, then verifies:

  • both recommendations pass catalog validation
  • the actionable count is nonzero
  • live and retired catalogs produce the expected diff
  • replacement URLs are locale-neutral
  • the proposal includes retirement reasons, reason codes, criteria, and issue-body source-of-truth instructions
  • the existing configuration suite preserves read-only audit permissions and trusted issue-only publication

Validation

  • npm run test:gallery-audit (65 passed)
  • npm run gallery:audit:fixtures
  • npm run build
  • editor diagnostics: clean

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Fixes promotion failures caused by localized Copilot replacement URLs by normalizing relatedUrl values before catalog validation.

Changes:

  • Canonicalize Copilot-provided replacement URLs.
  • Add regression coverage through promotion and proposal rendering.
File Description
scripts/​gallery-audit/​test/​audit.test.mjs Covers localized URL promotion and proposal output.
scripts/​gallery-audit/​copilot.mjs Canonicalizes validated replacement URLs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sajeetharan
Sajeetharan (sajeetharan) merged commit 9b32aa4 into main Sep 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants