Repository navigation
Enhance Vally evaluation output and reporting - #288
Merged
Merged
Conversation
- Added detailed summaries for unresolved failures, including inline evidence and links to failed steps. - Improved error handling and logging for evaluation attempts. - Introduced new functions for summarizing evaluation results and extracting error messages. - Updated tests to cover new summary features and ensure accurate reporting of evaluation outcomes.
…s artifacts and improved test linking in summaries
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An uncaught parse error on a truncated JSONL record prevents the publisher from reporting persisted termination errors and writing either summary output.
1 open issue
What changed in this PR
Improves Vally evaluation reporting with failure-focused GitHub Actions summaries while keeping detailed results available in downloadable artifacts.
Changes:
- Shows unresolved failures with compact evidence and links to test definitions and pipeline steps.
- Records evaluation attempts and process errors to support summary generation.
- Adds summary tests and documents the reporting behavior.
| File | Description |
|---|---|
scripts/eval.mjs |
Persists attempt status, errors, and result-file paths. |
scripts/eval-summary.test.mjs |
Tests summaries, error handling, source links, and artifact integration. |
scripts/eval-summary.mjs |
Generates failure-focused summaries from recorded attempts. |
scripts/eval-retry.mjs |
Exposes threshold-aware failed-trial selection. |
README.md |
Documents summaries and downloadable results. |
package.json |
Includes summary tests in the evaluation test command. |
.github/workflows/evals.yml |
Captures logs, publishes summaries, and links artifacts and failed steps. |
Review effort: Balanced
Refactor readAttempts function to handle file read errors gracefully and collect multiple error messages. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Laurent Nguyen <laurent.nguyen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Improve summary page of the eval:
Type of Change
Checklist
npm run validateand it passed{prefix}-{description}.mdtitle,impact,tags)For New Rules
Rule file:
skills/cosmosdb-best-practices/rules/_____.mdCategory:
Impact level:
Why is this rule important?
Agent Testing
Related Issues
Additional Notes