Skip to content

feat(core/core-util): migrate to #platform/* imports#38208

Merged
deyaaeldeen merged 3 commits intomainfrom
platform-imports/core-util
Apr 27, 2026
Merged

feat(core/core-util): migrate to #platform/* imports#38208
deyaaeldeen merged 3 commits intomainfrom
platform-imports/core-util

Conversation

@deyaaeldeen
Copy link
Copy Markdown
Member

@deyaaeldeen deyaaeldeen commented Apr 18, 2026

Migrate @azure/core-util build config to per-platform tsconfigs under config/, update eslint and vitest configs. No source changes — this package has no platform-specific code.

@deyaaeldeen deyaaeldeen force-pushed the platform-imports/core-util branch 6 times, most recently from f51261d to c3c1fd4 Compare April 20, 2026 16:17
@deyaaeldeen deyaaeldeen marked this pull request as ready for review April 20, 2026 19:18
@deyaaeldeen deyaaeldeen requested a review from a team as a code owner April 20, 2026 19:18
Copilot AI review requested due to automatic review settings April 20, 2026 19:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates @azure/core-util’s build/test/lint configuration to the repo’s per-platform config/-scoped tsconfigs (for browser/react-native/esm/cjs) and updates Vitest and ESLint wiring accordingly, without changing the library source.

Changes:

  • Add per-platform Warp build targets pointing at package-local config/tsconfig.src.*.json.
  • Replace root-level tsconfig files with config/ equivalents and update TS project references.
  • Switch browser Vitest config to the shared eng/vitestconfigs/browser.config.ts and add a flat eslint.config.mjs.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/core/core-util/warp.config.yml Overrides Warp targets to use package-local per-platform tsconfigs.
sdk/core/core-util/vitest.browser.config.ts Re-exports the shared browser Vitest config from eng/vitestconfigs/.
sdk/core/core-util/package.json Updates test scripts to run tsc -b --noEmit and simplifies Vitest invocation.
sdk/core/core-util/eslint.config.mjs Adds ESLint flat config pointing at config/tsconfig.lint.json.
sdk/core/core-util/tsconfig.json Updates project references to new config/ tsconfigs.
sdk/core/core-util/config/* Adds per-platform src/test/snippets/lint tsconfigs used by build/test/lint.
sdk/core/core-util/review/core-util-browser.api.diff.md Adds browser-vs-node API report diff artifact for review.
(deleted) sdk/core/core-util/tsconfig.*.json Removes legacy root-level tsconfig files replaced by config/ versions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@deyaaeldeen deyaaeldeen force-pushed the platform-imports/core-util branch from 103fe7a to 69849d4 Compare April 24, 2026 23:38
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread sdk/core/core-util/test/public/error.spec.ts
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@deyaaeldeen deyaaeldeen requested a review from jeremymeng April 27, 2026 17:36
@deyaaeldeen deyaaeldeen merged commit 9a75746 into main Apr 27, 2026
13 checks passed
@deyaaeldeen deyaaeldeen deleted the platform-imports/core-util branch April 27, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants