feat(core/core-util): migrate to #platform/* imports#38208
Merged
deyaaeldeen merged 3 commits intomainfrom Apr 27, 2026
Merged
Conversation
f51261d to
c3c1fd4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates @azure/core-util’s build/test/lint configuration to the repo’s per-platform config/-scoped tsconfigs (for browser/react-native/esm/cjs) and updates Vitest and ESLint wiring accordingly, without changing the library source.
Changes:
- Add per-platform Warp build targets pointing at package-local
config/tsconfig.src.*.json. - Replace root-level tsconfig files with
config/equivalents and update TS project references. - Switch browser Vitest config to the shared
eng/vitestconfigs/browser.config.tsand add a flateslint.config.mjs.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/core-util/warp.config.yml | Overrides Warp targets to use package-local per-platform tsconfigs. |
| sdk/core/core-util/vitest.browser.config.ts | Re-exports the shared browser Vitest config from eng/vitestconfigs/. |
| sdk/core/core-util/package.json | Updates test scripts to run tsc -b --noEmit and simplifies Vitest invocation. |
| sdk/core/core-util/eslint.config.mjs | Adds ESLint flat config pointing at config/tsconfig.lint.json. |
| sdk/core/core-util/tsconfig.json | Updates project references to new config/ tsconfigs. |
| sdk/core/core-util/config/* | Adds per-platform src/test/snippets/lint tsconfigs used by build/test/lint. |
| sdk/core/core-util/review/core-util-browser.api.diff.md | Adds browser-vs-node API report diff artifact for review. |
| (deleted) sdk/core/core-util/tsconfig.*.json | Removes legacy root-level tsconfig files replaced by config/ versions. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
103fe7a to
69849d4
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jeremymeng
reviewed
Apr 27, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jeremymeng
approved these changes
Apr 27, 2026
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
@azure/core-utilbuild config to per-platform tsconfigs underconfig/, update eslint and vitest configs. No source changes — this package has no platform-specific code.