Skip to content

feat(core/core-tracing): migrate to #platform/* imports#38207

Merged
deyaaeldeen merged 2 commits intomainfrom
platform-imports/core-tracing
Apr 25, 2026
Merged

feat(core/core-tracing): migrate to #platform/* imports#38207
deyaaeldeen merged 2 commits intomainfrom
platform-imports/core-tracing

Conversation

@deyaaeldeen
Copy link
Copy Markdown
Member

@deyaaeldeen deyaaeldeen commented Apr 18, 2026

Migrate @azure/core-tracing to #platform/* conditional imports:

  • #platform/state — platform-specific global state storage (CJS/ESM/browser)
  • Per-platform tsconfigs under config/, updated eslint/vitest/warp configs

@deyaaeldeen deyaaeldeen force-pushed the platform-imports/core-tracing branch 8 times, most recently from fe05917 to aaf041f Compare April 19, 2026 17:32
@deyaaeldeen deyaaeldeen marked this pull request as ready for review April 20, 2026 19:19
@deyaaeldeen deyaaeldeen requested review from a team and maorleger as code owners April 20, 2026 19:19
Copilot AI review requested due to automatic review settings April 20, 2026 19:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates @azure/core-tracing to use #platform/* conditional imports (starting with #platform/state) and aligns the package’s build/test configuration with the repo’s newer per-platform config/ tsconfig layout.

Changes:

  • Introduces #platform/state and routes platform-specific state via package.json#imports + per-platform state modules.
  • Reorganizes TypeScript project references into sdk/core/core-tracing/config/*.json and updates Warp/Vitest/ESLint configs accordingly.
  • Updates Vitest browser config to re-export the shared repo browser config.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/core/core-tracing/warp.config.yml Points Warp targets at per-platform tsconfigs under ./config/.
sdk/core/core-tracing/vitest.config.ts Updates aliasing for the renamed CJS state artifact.
sdk/core/core-tracing/vitest.browser.config.ts Switches to re-export the shared eng/vitestconfigs/browser.config.ts.
sdk/core/core-tracing/tsconfig.json Replaces legacy tsconfig references with ./config/* references.
sdk/core/core-tracing/package.json Updates sample/test scripts and adds imports mapping for #platform/state.
sdk/core/core-tracing/src/instrumenter.ts Switches state import from ./state.js to #platform/state.
sdk/core/core-tracing/src/state.ts Updates the shared-state bridge to reference the renamed CJS state file.
sdk/core/core-tracing/src/state-web.mts Tightens typing of the browser state singleton.
sdk/core/core-tracing/src/state-cjs.ts Tightens typing of the CJS state singleton.
sdk/core/core-tracing/eslint.config.mjs Adds local ESLint flat config pointing at config/tsconfig.lint.json.
sdk/core/core-tracing/config/tsconfig.*.json Adds new per-platform src/test/lint/samples/snippets tsconfigs.
sdk/core/core-tracing/tsconfig.*.json (deleted) Removes legacy root-level tsconfigs in favor of config/.

Comment thread sdk/core/core-tracing/package.json
Comment thread sdk/core/core-tracing/vitest.config.ts
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@deyaaeldeen deyaaeldeen force-pushed the platform-imports/core-tracing branch from 74dae6d to e5ba446 Compare April 24, 2026 23:38
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@deyaaeldeen deyaaeldeen merged commit 581ec12 into main Apr 25, 2026
12 checks passed
@deyaaeldeen deyaaeldeen deleted the platform-imports/core-tracing branch April 25, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants