feat(core/core-tracing): migrate to #platform/* imports#38207
Merged
deyaaeldeen merged 2 commits intomainfrom Apr 25, 2026
Merged
feat(core/core-tracing): migrate to #platform/* imports#38207deyaaeldeen merged 2 commits intomainfrom
deyaaeldeen merged 2 commits intomainfrom
Conversation
fe05917 to
aaf041f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates @azure/core-tracing to use #platform/* conditional imports (starting with #platform/state) and aligns the package’s build/test configuration with the repo’s newer per-platform config/ tsconfig layout.
Changes:
- Introduces
#platform/stateand routes platform-specific state viapackage.json#imports+ per-platform state modules. - Reorganizes TypeScript project references into
sdk/core/core-tracing/config/*.jsonand updates Warp/Vitest/ESLint configs accordingly. - Updates Vitest browser config to re-export the shared repo browser config.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/core-tracing/warp.config.yml | Points Warp targets at per-platform tsconfigs under ./config/. |
| sdk/core/core-tracing/vitest.config.ts | Updates aliasing for the renamed CJS state artifact. |
| sdk/core/core-tracing/vitest.browser.config.ts | Switches to re-export the shared eng/vitestconfigs/browser.config.ts. |
| sdk/core/core-tracing/tsconfig.json | Replaces legacy tsconfig references with ./config/* references. |
| sdk/core/core-tracing/package.json | Updates sample/test scripts and adds imports mapping for #platform/state. |
| sdk/core/core-tracing/src/instrumenter.ts | Switches state import from ./state.js to #platform/state. |
| sdk/core/core-tracing/src/state.ts | Updates the shared-state bridge to reference the renamed CJS state file. |
| sdk/core/core-tracing/src/state-web.mts | Tightens typing of the browser state singleton. |
| sdk/core/core-tracing/src/state-cjs.ts | Tightens typing of the CJS state singleton. |
| sdk/core/core-tracing/eslint.config.mjs | Adds local ESLint flat config pointing at config/tsconfig.lint.json. |
| sdk/core/core-tracing/config/tsconfig.*.json | Adds new per-platform src/test/lint/samples/snippets tsconfigs. |
| sdk/core/core-tracing/tsconfig.*.json (deleted) | Removes legacy root-level tsconfigs in favor of config/. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
74dae6d to
e5ba446
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jeremymeng
approved these changes
Apr 25, 2026
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
@azure/core-tracingto#platform/*conditional imports:#platform/state— platform-specific global state storage (CJS/ESM/browser)config/, updated eslint/vitest/warp configs