feat(core/core-paging): migrate to #platform/* imports#38204
Merged
deyaaeldeen merged 2 commits intomainfrom Apr 24, 2026
Merged
feat(core/core-paging): migrate to #platform/* imports#38204deyaaeldeen merged 2 commits intomainfrom
deyaaeldeen merged 2 commits intomainfrom
Conversation
deyaaeldeen
force-pushed
the
platform-imports/core-paging
branch
5 times, most recently
from
f2c495b to
c2c8802
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
deyaaeldeen
force-pushed
the
platform-imports/core-paging
branch
from
c2c8802 to
ddcc5cf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates @azure/core-paging’s build and tooling configuration to align with the repo’s per-platform #platform/*-style setup by moving to per-platform tsconfigs under config/ and wiring them into warp, Vitest, and ESLint.
Changes:
- Add per-platform warp targets pointing at
./config/tsconfig.src.*.json. - Replace root-level tsconfig files with
config/-scoped tsconfigs and update solution references. - Align Vitest browser config with the shared
eng/vitestconfigs/browser.config.tsand update scripts accordingly.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/core-paging/warp.config.yml | Adds explicit browser/react-native/esm/cjs targets using config/ tsconfigs. |
| sdk/core/core-paging/vitest.browser.config.ts | Switches to shared eng browser Vitest config export. |
| sdk/core/core-paging/tsconfig.test.node.json | Removes old root-level node test tsconfig (migrated to config/). |
| sdk/core/core-paging/tsconfig.test.json | Removes old umbrella test references tsconfig (now handled via config/ refs). |
| sdk/core/core-paging/tsconfig.src.json | Removes old src tsconfig (replaced by per-platform configs in config/). |
| sdk/core/core-paging/tsconfig.snippets.json | Removes old snippets tsconfig (migrated to config/). |
| sdk/core/core-paging/tsconfig.samples.json | Removes old samples tsconfig (migrated to config/). |
| sdk/core/core-paging/tsconfig.json | Updates project references to the new per-platform config/ tsconfigs. |
| sdk/core/core-paging/tsconfig.browser.config.json | Removes old browser config tsconfig (migrated to config/). |
| sdk/core/core-paging/package.json | Updates build:samples path and adjusts test scripts to run typecheck + Vitest. |
| sdk/core/core-paging/eslint.config.mjs | Adds flat ESLint config using config/tsconfig.lint.json for typed linting. |
| sdk/core/core-paging/config/tsconfig.test.react-native.json | Adds RN test tsconfig extending shared eng template with local path mappings. |
| sdk/core/core-paging/config/tsconfig.test.browser.json | Adds browser test tsconfig extending shared eng template with local path mappings. |
| sdk/core/core-paging/config/tsconfig.src.react-native.json | Adds RN src tsconfig extending shared eng template. |
| sdk/core/core-paging/config/tsconfig.src.browser.json | Adds browser src tsconfig extending shared eng template. |
jeremymeng
approved these changes
Apr 24, 2026
Member
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
I wonder whether we'd want do do anything differently/any room for improvement for platform-agnostic package like this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
@azure/core-pagingbuild config to per-platform tsconfigs underconfig/, update eslint and vitest configs. No source changes — this package has no platform-specific code.