feat(core/core-http-compat): migrate to #platform/* imports#38202
Merged
deyaaeldeen merged 3 commits intomainfrom Apr 27, 2026
Merged
feat(core/core-http-compat): migrate to #platform/* imports#38202deyaaeldeen merged 3 commits intomainfrom
deyaaeldeen merged 3 commits intomainfrom
Conversation
84f835c to
192ecfd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates @azure/core-http-compat to the repo’s per-platform build/test configuration approach by moving to config/ tsconfigs and aligning Warp, ESLint, and Vitest configuration accordingly (without changing runtime source).
Changes:
- Update Warp to build via per-platform tsconfigs under
./config/. - Replace root tsconfig files with project references to
./config/*tsconfigs (src/test/snippets). - Align Vitest browser config and add a flat ESLint config that points at
./config/tsconfig.lint.json.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/core-http-compat/warp.config.yml | Overrides Warp base targets to use per-platform config/ tsconfigs. |
| sdk/core/core-http-compat/vitest.browser.config.ts | Switches to shared browser Vitest config export from eng/vitestconfigs. |
| sdk/core/core-http-compat/tsconfig.test.node.json | Removes old node test tsconfig at package root (moved under config/). |
| sdk/core/core-http-compat/tsconfig.test.json | Removes old aggregate test tsconfig at package root (replaced by per-platform refs in tsconfig.json). |
| sdk/core/core-http-compat/tsconfig.src.json | Removes old src tsconfig at package root (replaced by per-platform refs in tsconfig.json). |
| sdk/core/core-http-compat/tsconfig.snippets.json | Removes old snippets tsconfig at package root (moved under config/). |
| sdk/core/core-http-compat/tsconfig.samples.json | Removes old samples tsconfig (package scripts indicate samples are skipped). |
| sdk/core/core-http-compat/tsconfig.json | Updates project references to point at per-platform config/ tsconfigs. |
| sdk/core/core-http-compat/tsconfig.browser.config.json | Removes old browser config tsconfig at package root (replaced by per-platform configs). |
| sdk/core/core-http-compat/package.json | Updates test scripts to run tsc -b --noEmit before running Vitest, and simplifies test:node/browser scripts. |
| sdk/core/core-http-compat/eslint.config.mjs | Adds flat ESLint config using Azure SDK shared config plus project-aware parserOptions. |
| sdk/core/core-http-compat/config/tsconfig.test.react-native.json | Adds React Native test tsconfig under config/. |
| sdk/core/core-http-compat/config/tsconfig.test.browser.json | Adds browser test tsconfig under config/. |
| sdk/core/core-http-compat/config/tsconfig.src.react-native.json | Adds React Native src tsconfig under config/. |
| sdk/core/core-http-compat/config/tsconfig.src.browser.json | Adds browser src tsconfig under config/. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bbe68e5 to
64f1e15
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jeremymeng
reviewed
Apr 27, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jeremymeng
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
@azure/core-http-compatbuild config to per-platform tsconfigs underconfig/, update eslint and vitest configs. No source changes — this package has no platform-specific code.