Skip to content

feat(core/core-http-compat): migrate to #platform/* imports#38202

Merged
deyaaeldeen merged 3 commits intomainfrom
platform-imports/core-http-compat
Apr 27, 2026
Merged

feat(core/core-http-compat): migrate to #platform/* imports#38202
deyaaeldeen merged 3 commits intomainfrom
platform-imports/core-http-compat

Conversation

@deyaaeldeen
Copy link
Copy Markdown
Member

@deyaaeldeen deyaaeldeen commented Apr 18, 2026

Migrate @azure/core-http-compat build config to per-platform tsconfigs under config/, update eslint and vitest configs. No source changes — this package has no platform-specific code.

@deyaaeldeen deyaaeldeen force-pushed the platform-imports/core-http-compat branch 7 times, most recently from 84f835c to 192ecfd Compare April 20, 2026 16:37
@deyaaeldeen deyaaeldeen marked this pull request as ready for review April 24, 2026 19:16
@deyaaeldeen deyaaeldeen requested a review from a team as a code owner April 24, 2026 19:16
Copilot AI review requested due to automatic review settings April 24, 2026 19:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates @azure/core-http-compat to the repo’s per-platform build/test configuration approach by moving to config/ tsconfigs and aligning Warp, ESLint, and Vitest configuration accordingly (without changing runtime source).

Changes:

  • Update Warp to build via per-platform tsconfigs under ./config/.
  • Replace root tsconfig files with project references to ./config/* tsconfigs (src/test/snippets).
  • Align Vitest browser config and add a flat ESLint config that points at ./config/tsconfig.lint.json.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/core/core-http-compat/warp.config.yml Overrides Warp base targets to use per-platform config/ tsconfigs.
sdk/core/core-http-compat/vitest.browser.config.ts Switches to shared browser Vitest config export from eng/vitestconfigs.
sdk/core/core-http-compat/tsconfig.test.node.json Removes old node test tsconfig at package root (moved under config/).
sdk/core/core-http-compat/tsconfig.test.json Removes old aggregate test tsconfig at package root (replaced by per-platform refs in tsconfig.json).
sdk/core/core-http-compat/tsconfig.src.json Removes old src tsconfig at package root (replaced by per-platform refs in tsconfig.json).
sdk/core/core-http-compat/tsconfig.snippets.json Removes old snippets tsconfig at package root (moved under config/).
sdk/core/core-http-compat/tsconfig.samples.json Removes old samples tsconfig (package scripts indicate samples are skipped).
sdk/core/core-http-compat/tsconfig.json Updates project references to point at per-platform config/ tsconfigs.
sdk/core/core-http-compat/tsconfig.browser.config.json Removes old browser config tsconfig at package root (replaced by per-platform configs).
sdk/core/core-http-compat/package.json Updates test scripts to run tsc -b --noEmit before running Vitest, and simplifies test:node/browser scripts.
sdk/core/core-http-compat/eslint.config.mjs Adds flat ESLint config using Azure SDK shared config plus project-aware parserOptions.
sdk/core/core-http-compat/config/tsconfig.test.react-native.json Adds React Native test tsconfig under config/.
sdk/core/core-http-compat/config/tsconfig.test.browser.json Adds browser test tsconfig under config/.
sdk/core/core-http-compat/config/tsconfig.src.react-native.json Adds React Native src tsconfig under config/.
sdk/core/core-http-compat/config/tsconfig.src.browser.json Adds browser src tsconfig under config/.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@deyaaeldeen deyaaeldeen force-pushed the platform-imports/core-http-compat branch from bbe68e5 to 64f1e15 Compare April 24, 2026 23:38
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread sdk/core/core-http-compat/package.json Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@deyaaeldeen deyaaeldeen requested a review from jeremymeng April 27, 2026 17:30
@deyaaeldeen deyaaeldeen merged commit 2002fc7 into main Apr 27, 2026
13 checks passed
@deyaaeldeen deyaaeldeen deleted the platform-imports/core-http-compat branch April 27, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants