-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improve test coverage to ~100% for @azure/core-rest-pipeline #38180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
deyaaeldeen
merged 40 commits into
main
from
deyaaeldeen/core-rest-pipeline-test-coverage
Apr 24, 2026
Merged
Changes from 13 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
000df60
Improve test coverage to ~100% for @azure/core-rest-pipeline
0e9d166
Remove 'coverage' from test describe block names
0955ebe
Remove unnecessary SharedArrayBuffer runIf guard
4838e54
Clean up describe block names
5609083
Remove 'edge cases' from describe block names
2819c82
Use typed vi.importActual for node modules
5c6c82c
Format browser file test
fba631a
Strengthen isDefined-only assertions with value checks
178b1f9
Use typed mock APIs instead of casts in userAgentPlatform tests
d4b7d4e
Strengthen assertions and remove source line references in bearer tok…
c224090
Improve tracingPolicy test assertions
c635173
Extract repeated test constants into shared variables
e3ae4ec
Move imports to top level (vitest hoists vi.mock automatically)
374763f
Fix TS compilation errors and format test files
bf59a02
Address PR review feedback
1e36183
Merge remote-tracking branch 'origin/main' into deyaaeldeen/core-rest…
3ae1ebc
Strengthen policy factory tests with behavioral assertions
288e527
fix: address audit issues in core-rest-pipeline tests
459c0e4
fix: use isAtLeast in tokenCycler test
ca898a9
fix: use assert.isTrue instead of assert.equal(x, true) in nodeHttpCl…
4e076e3
fix: use assert.isFalse in fetchHttpClient browser test
ad087e7
fix: replace bare assert() with assert.isTrue in nodeHttpClient test
dd1f81b
refactor: modernize error assertions in core-client tests
ef088b2
refactor: modernize error assertions and spy patterns in core-rest-pi…
17a5ea9
refactor: second pass modernization in core-rest-pipeline tests
93e330d
refactor: third pass modernization in core-rest-pipeline tests
e127894
fix: remove foreign package files from core-rest-pipeline branch
a2df2d8
Replace bodySent boolean flags with vi.fn() in fetchHttpClient.spec.ts
2b33464
refactor: eliminate unnecessary type casts from core-rest-pipeline tests
ecf903e
Eliminate additional type casts in core-rest-pipeline tests
b041f37
Strengthen weak isDefined assertions in core-rest-pipeline tests
4895095
fix: restore original restError cast to avoid Function lint error
042b1b2
trigger CI re-run
e6d1d78
fix: resolve TS compilation errors in node test config
94d6341
Fix misleading test title for CAE challenge retry test
498a844
Replace isAbove(x.length, 0) with isNotEmpty for consistency
f5e738e
Improve assertion patterns in core-rest-pipeline tests
3ccd37f
Apply broad feedback patterns across pipeline tests
02031eb
Address Jeremy review feedback on pipeline tests
ddf9e96
Fix TS compilation: use string instead of BufferEncoding in vi.fn params
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.