Restore azuredeploy.json for Key Vault quickstart samples#14738
Closed
msmbaldwin wants to merge 1 commit intoAzure:masterfrom
Closed
Restore azuredeploy.json for Key Vault quickstart samples#14738msmbaldwin wants to merge 1 commit intoAzure:masterfrom
msmbaldwin wants to merge 1 commit intoAzure:masterfrom
Conversation
Re-adds azuredeploy.json (compiled from main.bicep) for the four Key Vault samples that lost it during the recent RBAC modernization PRs (Azure#14704, Azure#14705, Azure#14706, Azure#14707). The 'Deploy to Azure' buttons in the README files reference azuredeploy.json directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Closing — the AQT pipeline rejects multi-folder PRs. Splitting into four separate PRs (one per sample folder). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-adds
azuredeploy.json(compiled frommain.bicep) for the four Key Vault quickstart samples that lost the file during the recent RBAC modernization PRs:key-vault-createkey-vault-secret-createkey-vault-key-createkey-vault-certificate-createWhy was it deleted?
During the original PRs,
azuredeploy.jsonwas removed under the (incorrect) assumption that CI would regenerate the compiled JSON frommain.bicepautomatically. AQT doesn't do that — both files are expected to be committed by the contributor, and the "Deploy to Azure" / "Visualize" buttons in eachREADME.mdlink directly toazuredeploy.json. Restoring the file fixes those buttons.How was it generated?
Each
azuredeploy.jsonwas produced byaz bicep buildagainst the correspondingmain.bicepalready on master. No template logic changes.