Add non-persistent HNS network support for ACI#4355
Merged
behzad-mir merged 1 commit intomasterfrom May 5, 2026
Merged
Conversation
|
lgtm |
- Add HNSFlagEnableNonPersistent constant (value 8) for HNS v1 API - Modify createHnsNetwork() to accept nonPersistent parameter - CreateHnsNetwork() now always creates non-persistent networks for ACI - CreateDefaultExtNetwork() creates persistent networks (ext network) - Use anonymous struct to inject Flags field into HNS v1 JSON payload
81c0d4e to
089346b
Compare
tamilmani1989
approved these changes
May 5, 2026
jackieluc
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the EnableNonPersistent flag for all HNS v2 networks created via the CNI network package. This ensures networks are automatically removed after host reboot, preventing stale network accumulation.
Changes
Modified configureHcnNetwork() in network_windows.go to set hcn.EnableNonPersistent on all HCN networks
Refactored the FrontendNIC (transparent network) path to use |= for flag combination
Motivation
HNS networks that persist across reboots can accumulate and cause issues. By making all networks non-persistent, we ensure clean state after host restarts.
Test
The Test shows Flags: 8 for the HCN network in non-persistant.