Skip to content

Fixes to prep for Grafana 13#9891

Open
ABZhang0 wants to merge 5 commits into
Azure:mainfrom
ABZhang0:g13-api-update
Open

Fixes to prep for Grafana 13#9891
ABZhang0 wants to merge 5 commits into
Azure:mainfrom
ABZhang0:g13-api-update

Conversation

@ABZhang0
Copy link
Copy Markdown
Contributor

@ABZhang0 ABZhang0 commented May 20, 2026

Related command

az grafana data-source, az grafana backup, az grafana restore, az grafana integration, az grafana managed-private-endpoint

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copilot AI review requested due to automatic review settings May 20, 2026 22:19
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented May 20, 2026

❌Azure CLI Extensions Breaking Change Test
❌amg
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove grafana api-key sub group grafana api-key removed please confirm sub group grafana api-key removed
1012 - SubgroupRemove grafana integrations sub group grafana integrations removed please confirm sub group grafana integrations removed
1002 - CmdRemove grafana list-available-plugin cmd grafana list-available-plugin removed please confirm cmd grafana list-available-plugin removed
1012 - SubgroupRemove grafana mpe sub group grafana mpe removed please confirm sub group grafana mpe removed
1012 - SubgroupRemove grafana notification-channel sub group grafana notification-channel removed please confirm sub group grafana notification-channel removed
⚠️ 1004 - CmdPropRemove grafana backup cmd grafana backup removed property is_preview
⚠️ 1011 - SubgroupAdd grafana integration sub group grafana integration added
⚠️ 1011 - SubgroupAdd grafana managed-private-endpoint sub group grafana managed-private-endpoint added
⚠️ 1011 - SubgroupAdd grafana plugin sub group grafana plugin added
⚠️ 1004 - CmdPropRemove grafana restore cmd grafana restore removed property is_preview

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 20, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

@github-actions github-actions Bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the amg Azure CLI extension to prepare for Grafana 13 by removing deprecated command surfaces and migrating data-source operations away from deprecated ID-based Grafana APIs.

Changes:

  • Remove deprecated az grafana notification-channel and az grafana api-key command groups (and related docs/help).
  • Update az grafana data-source update to use the UID-based endpoint and drop ID-based data source lookup.
  • Promote backup, restore, and integrations monitor commands from preview to GA; bump extension version to 2.9.0.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/amg/setup.py Bumps extension version to 2.9.0.
src/amg/README.md Removes notification-channel documentation snippet.
src/amg/HISTORY.rst Adds 2.9.0 release notes for Grafana 13 prep and GA commands.
src/amg/azext_amg/tests/latest/recordings/test_amg_e2e.yaml Updates recording to reflect UID-based datasource update endpoint.
src/amg/azext_amg/custom.py Switches datasource update to /uid/ endpoint; removes notification-channel and api-key implementations; adjusts datasource resolution logic.
src/amg/azext_amg/commands.py Removes deprecated command groups; marks backup/restore/integrations monitor as GA.
src/amg/azext_amg/_params.py Updates data_source argument help to reflect name/UID resolution only; removes api-key/notification-channel params.
src/amg/azext_amg/_help.py Removes help entries for deprecated command groups.

Comment thread src/amg/azext_amg/custom.py Outdated
Comment thread src/amg/HISTORY.rst Outdated
Comment thread src/amg/azext_amg/_params.py Outdated
@github-actions github-actions Bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot extension/grafana az grafana

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants