Conversation
…koiralamsft/VMApplication-Extension into norakoirala/enableappevents
|
Please remove everything under bundle from the commits. bundle should already be part of .gitignore. We don't want to check-in compilation/build outputs. |
| return bytes.Equal(checkSumNew, checkSum), nil | ||
| } | ||
|
|
||
| func logApplicationEvents(downloadDir string, appName string, actionPerformed packageregistry.ActionEnum, errorMessageToReturn error, eem *extensionevents.ExtensionEventManager, actionPlan *ActionPlan) () { |
There was a problem hiding this comment.
We should definitely write any issues with application events to our own extension log, but we should never fail an operation due to this.
| stderrFileName := filepath.Join(downloadDir, "stderr") | ||
| stderrFile, err := os.Open(stderrFileName) | ||
| if err != nil { | ||
| errorMessageToReturn = extensionerrors.CombineErrors(errorMessageToReturn, errors.Wrapf(err, "Error opening std err file for application %s", appName)) |
There was a problem hiding this comment.
Please double check that CombineErrors is appropriate here - since I believe that returns an ErrorWIthClarification, which we may not want here since it won't have a clarification.
| assert.NoError(t, err, "operation should not throw error") | ||
| } | ||
|
|
||
| func TestPackageRegistryDeserialization_EnableAppEvents_DefaultToFalse(t *testing.T) { |
There was a problem hiding this comment.
Tests to verify the actual logging of stderr and stdout?
- Exceeding buffer size
- Exceeding event count
- Etc
|
bundle/windows/prod/vm-application-manager.zip is a part of this change. It should already be a part of .gitignore, and we no longer need to check-in this file to the repo. |
3 participants
No description provided.