feat(vscode): Update bundled codeful SDK 1.0.0-preview.3 by andrew-eldridge · Pull Request #9617 · Azure/LogicAppsUX

Andrew Eldridge (andrew-eldridge) · 2026-09-14T21:37:47Z

Commit Type

feature - New functionality
fix - Bug fix
refactor - Code restructuring without behavior change
perf - Performance improvement
docs - Documentation update
test - Test-related changes
chore - Maintenance/tooling

Risk Level

Low - Minor changes, limited scope
Medium - Moderate changes, some user impact
High - Major changes, significant user/system impact

What & Why

Update bundled codeful SDK to version 1.0.0-preview.2

Impact of Change

Users: Adds new codeful sdk functionality with 1.0.0-preview.2 update
Developers: N/A
System: N/A

Test Plan

Unit tests added/updated
E2E tests added/updated
Manual testing completed
Tested in:

Contributors

Andrew Eldridge (@andrew-eldridge)

…deful-sdk-update-9-14

github-actions · 2026-09-14T21:38:36Z

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

Current: feat(vscode): Update bundled codeful SDK 1.0.0-preview.3
Issue: The title is specific and accurately identifies the VS Code area and SDK version being bundled.
Recommendation: No change required.

✅ Commit Type

The feature commit type is selected and the PR introduces updated Codeful SDK functionality and codeful connector path support.
Only one commit type is selected, which is appropriate. Although the PR also contains bug-fix behavior, selecting one primary type is acceptable.

❌ Risk Level

The PR body selects Medium, and the risk:medium label matches that selection. However, the diff indicates a higher advised risk: High.
This PR updates a bundled preview SDK, changes runtime SDK discovery and cache invalidation, modifies generated project dependencies, changes language-server assets, and adds shared path parsing behavior used by multiple designer packages. Please reassess the risk as High or explain why these broader runtime and user-facing changes remain medium risk.

❌ What & Why

Current: Update bundled codeful SDK to version 1.0.0-preview.2
Issue: The description identifies the wrong SDK version. The diff updates the bundled SDK to 1.0.0-preview.3. It also introduces codeful connector path parsing and preserves native interpolation expressions in path parameters, which are not documented.
Recommendation: Update this section to describe the actual scope, for example: Update the bundled Codeful SDK and generated project references to 1.0.0-preview.3, and support parsing codeful connector paths without rewriting native interpolation expressions.

❌ Impact of Change

The impact section is present, but it is incomplete and includes an inaccurate SDK version. Developers and system impact are incorrectly listed as N/A despite changes to shared parsing utilities, language-server asset selection, project generation, cache invalidation, and package/version constants.
Recommendation:
- Users: VS Code users creating or editing codeful workflows receive SDK 1.0.0-preview.3 and improved handling of connector paths containing encoded or native interpolation expressions.
- Developers: Generated Codeful projects, SDK package discovery, cache invalidation, language-server startup, and shared designer path parsing now use centralized SDK constants and codeful path parsing helpers.
- System: The bundled LSP SDK asset and generated NuGet references change from preview.1 to preview.3. Runtime dependency detection now requires the exact SDK package filename, and shared designer behavior changes in both designer packages.

✅ Test Plan

Unit tests are added or updated in the diff, including new coverage for codeful connector path parsing, operation selection, path parameter mapping, language-server behavior, and SDK-related constants. Under the review rules, unit tests are sufficient; E2E tests are not required.

⚠️ Contributors

@andrew-eldridge is credited. Consider also crediting PMs, designers, or reviewers who contributed to the behavior or requirements, if applicable.

⚠️ Screenshots/Videos

No screenshots or videos are included. This is acceptable because the primary changes are SDK, language-server, project-generation, and parsing behavior rather than a clearly visual UI change.

Summary Table

Section	Status	Recommendation
Title	✅	No change required.
Commit Type	✅	Keep the single `feature` selection.
Risk Level	❌	Reassess as `High`; the advised risk is higher than the submitted Medium level.
What & Why	❌	Correct preview.2 to preview.3 and describe the codeful path parsing scope.
Impact of Change	❌	Document user, developer, and system impacts; remove `N/A` entries.
Test Plan	✅	Unit test coverage is present in the diff.
Contributors	⚠️	Add other contributors if applicable.
Screenshots/Videos	⚠️	Not required for this primarily non-visual change.

Please update the SDK version and scope in the PR body, expand the impact details, and reassess the risk level. The PR currently does not pass because the body contains inaccurate and incomplete required information.

Powered by: Logic App (fallback) | Last updated: Fri, 23 Oct 2026 21:05:20 GMT

github-actions · 2026-09-14T21:39:57Z

📊 Coverage Check

The following changed files need attention:

⚠️ apps/vs-code-designer/src/app/commands/workflows/switchToDotnetProject.ts - 74% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/utils/codeful.ts - 72% covered (needs improvement)
⚠️ libs/designer-v2/src/lib/core/utils/parameters/helper.ts - 57% covered (needs improvement)
⚠️ libs/designer/src/lib/core/utils/parameters/helper.ts - 42% covered (needs improvement)

Please add tests for the uncovered files before merging.

Copilot

🟡 Changes recommended

Address the SDK compatibility, stale-package selection, unused import, and missing template replacement coverage issues.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates the VS Code designer to use Codeful SDK 1.0.0-preview.2.

Changes:

Centralizes SDK versions and package naming.
Updates project templates, language-server setup, cache handling, and conversion logic.
Refreshes related tests and bundled SDK references.

File summaries

File	Summary
`apps/vs-code-designer/src/test/ui/run-e2e.ts`	Updates SDK asset usage.
`apps/vs-code-designer/src/constants.ts`	Adds centralized SDK constants.
`apps/vs-code-designer/src/assets/CodefulProjectTemplate/CodefulProj`	Uses the generated SDK version.
`apps/vs-code-designer/src/app/utils/languageServerProtocolConstants.ts`	Removes relocated constants.
`apps/vs-code-designer/src/app/utils/languageServerProtocol.ts`	Installs the updated SDK package.
`apps/vs-code-designer/src/app/utils/codeful.ts`	Updates SDK cache handling.
`apps/vs-code-designer/src/app/utils/__test__/verifyIsProject.test.ts`	Updates project expectations.
`apps/vs-code-designer/src/app/utils/__test__/languageServerProtocol.test.ts`	Updates SDK installation tests.
`apps/vs-code-designer/src/app/utils/__test__/codeful.test.ts`	Updates cache path tests.
`apps/vs-code-designer/src/app/languageServer/languageServer.ts`	Locates the bundled SDK package.
`apps/vs-code-designer/src/app/languageServer/__test__/languageServer.test.ts`	Updates language-server expectations.
`apps/vs-code-designer/src/app/languageServer/__test__/bundledLspServerCodeLens.test.ts`	Updates bundled LSP setup and cleanup.
`apps/vs-code-designer/src/app/commands/workflows/switchToDotnetProject.ts`	Uses centralized SDK versions.
`apps/vs-code-designer/src/app/commands/workflows/__test__/switchToDotnetProject.test.ts`	Updates mocked SDK constants.
`apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppWorkspace.ts`	Substitutes the SDK version in new projects.

Review details

Files reviewed: 15/17 changed files
Comments generated: 4
Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  const projectNugetFolder = path.join(projectPath, '.nuget');
  const projectSdkHashMarkerPath = path.join(projectNugetFolder, codefulSdkProjectHashMarkerName);
-  const projectSdkPackagePath = path.join(projectNugetFolder, 'packages', codefulSdkPackageId.toLowerCase(), codefulSdkPackageVersion);
+  const projectSdkPackagePath = path.join(projectNugetFolder, 'packages', CodefulSdk.WorkflowsSDK.toLowerCase(), CodefulSdkVersion.WorkflowsSDK);


    const files = await fse.readdir(sdkFolderPath);
    const sdkNupkgFile = files.find((file) => {
-      return file.startsWith('Microsoft.Azure.Workflows.Sdk.') && file.endsWith('.nupkg');
+      return file.startsWith(`${CodefulSdk.WorkflowsSDK}.`) && file.endsWith('.nupkg');


+    const templateProjContent = (await fse.readFile(templateProjPath, 'utf-8'))
+      .replace(/<%= codefulSdkPackageVersion %>/g, CodefulSdkVersion.WorkflowsSDK);


…deful-sdk-update-9-14

Andrew Eldridge (andrew-eldridge) added 5 commits September 14, 2026 15:26

move codeful consts to constants.ts, replace hard-coded values

ec14c32

update bundled logic apps sdk nupkg

1251b3e

clean up consts

f872c4d

fix test

e5f7f1f

Merge branch 'main' of github.com:Azure/LogicAppsUX into aeldridge/co…

8509cc2

…deful-sdk-update-9-14

Andrew Eldridge (andrew-eldridge) requested review from Bryan Bennett (bjbennet) and Brian Lam (lambrianmsft) September 14, 2026 21:37

Andrew Eldridge (andrew-eldridge) added the VSCode Issues or PRs specific to VS Code extension label Sep 14, 2026

Copilot AI balanced review requested due to automatic review settings September 14, 2026 21:37

Andrew Eldridge (andrew-eldridge) added the risk:medium Medium risk change with potential impact label Sep 14, 2026

Copilot started reviewing on behalf of Andrew Eldridge (andrew-eldridge) September 14, 2026 21:38

View session

github-actions Bot added needs-pr-update pr-validated and removed needs-pr-update labels Sep 14, 2026

Andrew Eldridge (andrew-eldridge) marked this pull request as draft September 14, 2026 21:40

Copilot AI reviewed Sep 14, 2026

View reviewed changes

Andrew Eldridge (andrew-eldridge) added 9 commits September 15, 2026 00:54

fix issue where old sdk version possibly used by lsp server

4ec45fc

update codeful sdk

50df0d3

Merge branch 'main' of github.com:Azure/LogicAppsUX into aeldridge/co…

e32100d

…deful-sdk-update-9-14

Merge branch 'main' of github.com:Azure/LogicAppsUX into aeldridge/co…

cd047a9

…deful-sdk-update-9-14

update codeful sdk

cdce16f

update codeful sdk

d988c43

update codeful sdk

e2a28a6

handle codeful managed connector path parsing

fdb637b

Merge branch 'main' of github.com:Azure/LogicAppsUX into aeldridge/co…

05952a2

…deful-sdk-update-9-14

github-actions Bot added needs-pr-update and removed pr-validated labels Oct 20, 2026

update codeful sdk 1.0.0-preview.3

5271452

Andrew Eldridge (andrew-eldridge) changed the title ~~feat(vscode): Update bundled codeful SDK 1.0.0-preview.2~~ feat(vscode): Update bundled codeful SDK 1.0.0-preview.3 Oct 20, 2026

update sdk

a63c11c

Navigation Menu

Repository navigation

feat(vscode): Update bundled codeful SDK 1.0.0-preview.3 - #9617

feat(vscode): Update bundled codeful SDK 1.0.0-preview.3#9617
Andrew Eldridge (andrew-eldridge) wants to merge 16 commits into
mainfrom
aeldridge/codeful-sdk-update-9-14

Andrew Eldridge (andrew-eldridge) commented Sep 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const templateProjContent = (await fse.readFile(templateProjPath, 'utf-8'))
		.replace(/<%= codefulSdkPackageVersion %>/g, CodefulSdkVersion.WorkflowsSDK);

Conversation

Andrew Eldridge (andrew-eldridge) commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Commit Type

Risk Level

What & Why

Impact of Change

Test Plan

Contributors

Uh oh!

github-actions Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

✅ Commit Type

❌ Risk Level

❌ What & Why

❌ Impact of Change

✅ Test Plan

⚠️ Contributors

⚠️ Screenshots/Videos

Summary Table

Please update the SDK version and scope in the PR body, expand the impact details, and reassess the risk level. The PR currently does not pass because the body contains inaccurate and incomplete required information.

Uh oh!

github-actions Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Coverage Check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Andrew Eldridge (andrew-eldridge) commented Sep 14, 2026 •

edited

Loading

github-actions Bot commented Sep 14, 2026 •

edited

Loading

github-actions Bot commented Sep 14, 2026 •

edited

Loading