Skip to content

fix: distinguish run with payload tooltip #9564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mia Miao (miachillgood) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: distinguish run with payload tooltip #9564

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
224e07a
fix: distinguish run with payload tooltip
miachillgood Aug 23, 2026
e7d91ef
test: exercise payload tooltip behavior
miachillgood Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions libs/designer-v2/src/lib/ui/FloatingRunButton/__tests__/floatingRunButton.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,15 @@ describe('FloatingRunButton', () => {
expect(buttons.length).toBeGreaterThan(1);
});

it('should identify the payload action with a distinct tooltip', () => {
(LogicAppsShared.canRunBeInvokedWithPayload as Mock).mockReturnValue(true);

renderWithProviders(defaultProps);

const payloadButton = screen.getByRole('button', { name: 'Run with payload' });
expect(payloadButton).toHaveAttribute('title', 'Run with payload');

@miachillgood Mia Miao (miachillgood) Aug 23, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in e7d91ef. The regression test now focuses the payload action and asserts the rendered Fluent tooltip content.

});

it('should render split button in draft mode even when canRunBeInvokedWithPayload returns false', () => {
(LogicAppsShared.canRunBeInvokedWithPayload as Mock).mockReturnValue(false);

Expand Down
9 changes: 8 additions & 1 deletion libs/designer-v2/src/lib/ui/FloatingRunButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ export const FloatingRunButton = ({
);

const [popoverOpen, setPopoverOpen] = useState(false);
const [isPayloadButtonActive, setIsPayloadButtonActive] = useState(false);

if (isA2AWorkflow) {
return (
Expand All @@ -403,7 +404,7 @@ export const FloatingRunButton = ({
if (canBeRunWithPayload) {
return (
<div className={styles.container}>
<Tooltip withArrow content={tooltipText} relationship="description">
<Tooltip withArrow content={isPayloadButtonActive ? strings.RUN_PAYLOAD_TOOLTIP : tooltipText} relationship="description">
<SplitButton
{...buttonCommonProps}
primaryActionButton={{
Expand All @@ -415,7 +416,13 @@ export const FloatingRunButton = ({
}}
menuButton={{
icon: runIsLoading && runHasPayload ? <Spinner size="tiny" /> : <RunWithPayloadIcon />,
'aria-label': strings.RUN_PAYLOAD_TOOLTIP,
title: strings.RUN_PAYLOAD_TOOLTIP,

@miachillgood Mia Miao (miachillgood) Aug 23, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in e7d91ef. Removed the native title attribute and kept the Fluent tooltip plus accessible label.

onClick: () => setPopoverOpen(true),
onFocus: () => setIsPayloadButtonActive(true),
onBlur: () => setIsPayloadButtonActive(false),
onMouseEnter: () => setIsPayloadButtonActive(true),
onMouseLeave: () => setIsPayloadButtonActive(false),
ref: payloadButtonRef,
disabled: isDisabled || runIsLoading || !canBeRunWithPayload || !triggerId,
}}
Expand Down
Loading