test: add iptables monitor debug - #9414
Open
Alexander (QxBytes) wants to merge 3 commits into
Open
Conversation
iptables blocker binary inside the monitor is used during startup
the wait -n drain loop in cacheContainerImageComponents reaps any background job, so a failed background bcc install is misreported as a pull failure and its log is never surfaced. dump /var/log/bcc_installation.log and report bcc_pid liveness on failure to confirm the culprit.
Alexander (QxBytes)
marked this pull request as ready for review
September 8, 2026 17:24
Alexander (QxBytes)
requested review from
Devinwong,
Sri Harsha (SriHarsha001),
Abdul Asfari (aboodasfari),
Nishchay (awesomenix),
Ben Brady (benjamin-brady),
Calvin S. (calvin197),
Cameron Meissner (cameronmeissner),
Sylvain Boily (djsly),
fcher,
Ganeshkumar Ashokavardhanan (ganeshkumarashok),
janenotjung-hue,
Karen Chen (karenychen),
lilypan26,
Mark Ibrahim (mxj220),
Peter Damianov (pdamianov-dev),
Patrick W. Healy (phealy),
Artur Khantimirov (r2k1),
Runzhen (runzhen),
Shun Lyu (sinmentis),
sulixu,
Tim Wright (timmy-wright),
Thibault Cohen (titilambert),
Xu Xue (xuexu6666) and
Zachary (zachary-bailey)
as code owners
September 8, 2026 17:24
Alexander (QxBytes)
requested a review
from Abigail Liang (abigailliang-aks-sig-node)
as a code owner
September 8, 2026 17:24
github-actions
Bot
added
the
components
Contributor
Windows Unit Test Results 3 files 14 suites 56s ⏱️ Results for commit cef8efb. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Failure attribution can be incorrect, and required ShellSpec coverage and generated prefetch test data are missing.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Linux VHD caching for the Azure iptables monitor and diagnostics for background-job failures.
Changes:
- Adds
azure-iptables-monitor:v0.0.5-0for Linux AMD64/ARM64 VHDs. - Logs BCC state and installation output after background failures.
- Adds binary prefetch configuration.
File summaries
| File | Description |
|---|---|
vhdbuilder/packer/install-dependencies.sh |
Adds BCC failure diagnostics. |
parts/common/components.json |
Adds the iptables monitor image and binaries. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+309
to
+314
| "containerImagePrefetch": { | ||
| "latestVersion": { | ||
| "binaries": [ | ||
| "/azure-iptables-monitor", | ||
| "/azure-block-iptables" | ||
| ] |
Comment on lines
+760
to
+765
| diagnoseBackgroundJobFailure() { | ||
| local ret=$1 | ||
| local bcc_log="/var/log/bcc_installation.log" | ||
| echo "diagnoseBackgroundJobFailure: a background job exited with code ${ret}" >&2 | ||
| echo "diagnoseBackgroundJobFailure: BCC_PID=${BCC_PID:-<unset>}" >&2 | ||
| if [ -n "${BCC_PID:-}" ] && ! kill -0 "${BCC_PID}" 2>/dev/null; then |
Comment on lines
+765
to
+766
| if [ -n "${BCC_PID:-}" ] && ! kill -0 "${BCC_PID}" 2>/dev/null; then | ||
| echo "diagnoseBackgroundJobFailure: eBPF/BCC background install (PID ${BCC_PID}) has exited and is the likely source of exit ${ret} (ERR_BCC_INSTALL_TIMEOUT=170)" >&2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #