chore(deps): update node exporter to 1.12.1 - #9398
Conversation
github-actions
Bot
added
the
components
Windows Unit Test Results 3 files 14 suites 56s ⏱️ Results for commit a6aa6dd. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
🟡 Changes recommended
Both new version validators expect a leading v that real node-exporter 1.12.1 output does not contain.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the VHD-cached node exporter and expands validation of package versions, default collectors, and InfiniBand metrics.
Changes:
- Bumps node-exporter from 1.9.1 to 1.12.1 across supported Ubuntu and Azure Linux 3 images.
- Adds package/binary version checks to VHD content testing.
- Adds E2E validation for new collectors and InfiniBand hardware counters.
Package Update Analysis: node-exporter-kubernetes
Version change: 1.9.1 → 1.12.1 (minor update)
OS variants affected: Ubuntu 20.04, 22.04, 24.04, 26.04; Azure Linux 3.0
OS variants NOT updated: None among supported variants
Key upstream changes include:
- 🟡 New default collectors:
bcachefs,kernel_hung, anddmmultipath. - 🟡 New InfiniBand hardware-counter metrics and device filtering.
- 🟡 Behavioral changes to
mdadmand filesystem collection. - 🟢 New NVMe, NFS, EDAC, CPU-frequency, and network metrics.
- 🟢 Fixes for diskstats, filesystem, thermal-zone, perf, EDAC, netdev, and mountstats behavior.
- No upstream security fixes or explicit breaking CLI changes were identified in the official changelog.
VHD size impact: No artifact-size data is available; the additional collectors may cause a modest binary-size increase.
Overall risk: 🟡 Medium—this is a multi-minor runtime update introducing new default collection behavior. Candidate-VHD and InfiniBand validation remain appropriate before merge.
File summaries
| File | Description |
|---|---|
parts/common/components.json |
Pins node-exporter 1.12.1 packages for supported distributions. |
vhdbuilder/packer/test/linux-vhd-content-test.sh |
Adds package and executable version checks. |
e2e/validators.go |
Detects InfiniBand hardware and invokes collector validation. |
e2e/nodeexporter/metrics.go |
Parses metrics and validates new collectors and hardware counters. |
e2e/nodeexporter/metrics_test.go |
Adds collector-validation unit tests. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The new MANA startup behavior lacks the repository-required ShellSpec coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
The runtime dependency jump and MANA workaround require the quota-constrained candidate-VHD HPC validation noted in the PR.
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0 new
- Review effort level: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Optional exporter arguments can currently override the mandatory MANA suppression flag.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Balanced
Summary
MANA Lifecycle
Local Validation
Candidate Evidence And Remaining Validation
Candidate VHD build 179769249 validated the prior head 4e7085b: 237 passed, 70 skipped, zero failures; node exporter v1.12.1 ran on four MANA OS scenarios with InfiniBand suppressed. This predates the lifecycle corrections in a809912; fresh candidate validation is required.
Earlier assertions that the Ubuntu 20.04 mlx5_ib module-loaded banner proved hardware-counter coverage were too strong. No device inventory or successful branch/scrape evidence established that claim. The separate H100 GPU run used a main-built v1.9.1 VHD; A100 skipped on quota. Prefer existing GPU scenarios with candidate VHDs for additional InfiniBand assurance rather than creating a new expensive manual cluster.
Validate actual udev delivery and eventual exporter arguments on late attachment, including preservation of inactive-service state. Mocked unit tests and udev syntax verification do not replace this integration evidence.
Standalone E2E build 179769254 used main VHDs and failed two VM-running-state timeouts before exporter validation; it is not evidence of a candidate exporter regression.