Skip to content

Adding Az cli into e2e dockerfile#4752

Merged
rachelvweber merged 1 commit intomasterfrom
rachelvweber/ARO-23873
Apr 7, 2026
Merged

Adding Az cli into e2e dockerfile#4752
rachelvweber merged 1 commit intomasterfrom
rachelvweber/ARO-23873

Conversation

@rachelvweber
Copy link
Copy Markdown
Contributor

@rachelvweber rachelvweber commented Apr 3, 2026

Which issue this PR addresses:

https://redhat.atlassian.net/browse/ARO-23873?atlOrigin=eyJpIjoiNDhhYmYxYmVhODk1NGY1YzgzNzVkNDQxZmY0NGUwZTgiLCJwIjoiaiJ9

What this PR does / why we need it:

The e2e prow job keeps failing because the az cli isn't installed. Also, after speaking with Ben, removing entrypoint and exposing ports. We pass in the command that needs to run, and the exposed ports are unneeded.

Test plan for issue:

Tested by ci/prow/images job

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

I can't test this end to end until this is merged because the prow test is pointed at the master branch, but I confirmed that the image still builds correctly

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 3, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ARO E2E Docker image to include Azure CLI so the container can run E2E workflows that depend on az.

Changes:

  • Install Microsoft repo config and azure-cli into the ubi9/ubi-minimal runtime stage.
  • Switch to USER root for package installation, then back to USER 1000 for runtime.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rachelvweber rachelvweber force-pushed the rachelvweber/ARO-23873 branch from a539236 to 8ec9ea9 Compare April 6, 2026 18:14
@rachelvweber rachelvweber marked this pull request as draft April 6, 2026 18:41
@rachelvweber
Copy link
Copy Markdown
Contributor Author

/test all

1 similar comment
@rachelvweber
Copy link
Copy Markdown
Contributor Author

/test all

@rachelvweber rachelvweber force-pushed the rachelvweber/ARO-23873 branch from 5ccd1bf to f8129a2 Compare April 6, 2026 22:03
@rachelvweber
Copy link
Copy Markdown
Contributor Author

/test all

@rachelvweber rachelvweber changed the title Fixing e2e dockerfile Adding Az cli into e2e dockerfile Apr 6, 2026
@rachelvweber rachelvweber marked this pull request as ready for review April 7, 2026 00:42
Copilot AI review requested due to automatic review settings April 7, 2026 00:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@kevinobriendotca kevinobriendotca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed entrypoint not needed for current E2E pipeline. Startup command is passed in as part of the az container create --command-line args and also defined in the docker-compose.yml file.

@rachelvweber rachelvweber merged commit 1b0721e into master Apr 7, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants