Conversation
|
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Pull request overview
Updates the ARO E2E Docker image to include Azure CLI so the container can run E2E workflows that depend on az.
Changes:
- Install Microsoft repo config and
azure-cliinto theubi9/ubi-minimalruntime stage. - Switch to
USER rootfor package installation, then back toUSER 1000for runtime.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a539236 to
8ec9ea9
Compare
|
/test all |
1 similar comment
|
/test all |
5ccd1bf to
f8129a2
Compare
|
/test all |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kevinobriendotca
left a comment
There was a problem hiding this comment.
Confirmed entrypoint not needed for current E2E pipeline. Startup command is passed in as part of the az container create --command-line args and also defined in the docker-compose.yml file.
Which issue this PR addresses:
https://redhat.atlassian.net/browse/ARO-23873?atlOrigin=eyJpIjoiNDhhYmYxYmVhODk1NGY1YzgzNzVkNDQxZmY0NGUwZTgiLCJwIjoiaiJ9
What this PR does / why we need it:
The e2e prow job keeps failing because the az cli isn't installed. Also, after speaking with Ben, removing entrypoint and exposing ports. We pass in the command that needs to run, and the exposed ports are unneeded.
Test plan for issue:
Tested by ci/prow/images job
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
I can't test this end to end until this is merged because the prow test is pointed at the master branch, but I confirmed that the image still builds correctly