Skip to content

Revert flakey test changes and increase MUO SpecTimeout to 3 minutes#4701

Merged
hlipsig merged 3 commits intohlipsig/ARO-25407/fix-muo-gatekeeper-e2e-flakefrom
copilot/sub-pr-4700
Mar 20, 2026
Merged

Revert flakey test changes and increase MUO SpecTimeout to 3 minutes#4701
hlipsig merged 3 commits intohlipsig/ARO-25407/fix-muo-gatekeeper-e2e-flakefrom
copilot/sub-pr-4700

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 20, 2026

The previous attempt to fix flakey tests in test/e2e/operator.go replaced GetK8sObjectWithRetry with Eventually-based helpers and removed the SpecTimeout from the MUO deployment spec, risking unbounded hangs in the test suite.

Changes

  • Reverted test/e2e/operator.go to its original state, restoring GetK8sObjectWithRetry usage and removing the waitForMUODeploymentReady/waitForGatekeeperDeploymentReady helpers
  • Increased SpecTimeout on the MUO "must be restored if deleted" spec from 2*time.Minute3*time.Minute to reduce flakiness while preserving the suite-level hang protection
// Before
}, SpecTimeout(2*time.Minute))

// After
}, SpecTimeout(3*time.Minute))

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 20, 2026

Hi @copilot. Thanks for your PR.

I'm waiting for a Azure member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: hlipsig <8000786+hlipsig@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback on flakey tests: revert changes and increase timeout to 3 minutes Revert flakey test changes and increase MUO SpecTimeout to 3 minutes Mar 20, 2026
Copilot AI requested a review from hlipsig March 20, 2026 00:26
@hlipsig hlipsig merged commit b8451e7 into hlipsig/ARO-25407/fix-muo-gatekeeper-e2e-flake Mar 20, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants