Skip to content

feat: PR change gating — pre-incident PR risk review (DEV-1252) - #506

Merged
damianloch merged 30 commits into
mainfrom
sms10221/dev-1252-alert-prediction-via-change-gate
Jun 18, 2026
Merged

feat: PR change gating — pre-incident PR risk review (DEV-1252)#506
damianloch merged 30 commits into
mainfrom
sms10221/dev-1252-alert-prediction-via-change-gate

ci: install PyJWT in pre-checks so change_gating adapter/verdict test…

c53f8ad
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 12, 2026 in 1m 38s

Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 446 in server/tests/services/test_change_gating_adapter.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "is" operator with "==".

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Ocy_6-8DAyAu-wDP&open=AZ69Ocy_6-8DAyAu-wDP&pullRequest=506

Check warning on line 84 in server/services/change_gating/github_adapter.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant Exception class; it derives from another which is already caught.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Oc0y6-8DAyAu-wDT&open=AZ69Oc0y6-8DAyAu-wDT&pullRequest=506

Check warning on line 559 in client/src/components/github-provider-integration.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69OctW6-8DAyAu-wDM&open=AZ69OctW6-8DAyAu-wDM&pullRequest=506

Check failure on line 317 in server/tasks/github_webhook_tasks.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "RESET myapp.current_user_id; RESET myapp.current_org_id;" 3 times.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Oc146-8DAyAu-wDX&open=AZ69Oc146-8DAyAu-wDX&pullRequest=506

Check failure on line 348 in server/tasks/change_gating.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "logging.exception()" instead.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Oc2B6-8DAyAu-wDa&open=AZ69Oc2B6-8DAyAu-wDa&pullRequest=506

Check failure on line 700 in server/tasks/github_webhook_tasks.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Oc146-8DAyAu-wDY&open=AZ69Oc146-8DAyAu-wDY&pullRequest=506

Check failure on line 333 in server/routes/github/github_repo_selection.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "logging.exception()" instead.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Ocyx6-8DAyAu-wDN&open=AZ69Ocyx6-8DAyAu-wDN&pullRequest=506

Check failure on line 20 in server/tests/services/test_change_gating_adapter.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"TOKEN" detected here, make sure this is not a hard-coded secret.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Ocy_6-8DAyAu-wDO&open=AZ69Ocy_6-8DAyAu-wDO&pullRequest=506

Check warning on line 538 in server/tasks/change_gating.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this constructor call with a literal.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Oc2B6-8DAyAu-wDb&open=AZ69Oc2B6-8DAyAu-wDb&pullRequest=506

Check warning on line 84 in server/services/change_gating/github_adapter.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant Exception class; it derives from another which is already caught.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Oc0y6-8DAyAu-wDS&open=AZ69Oc0y6-8DAyAu-wDS&pullRequest=506

Check failure on line 100 in server/tests/tasks/test_change_gating_handler.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69OczH6-8DAyAu-wDQ&open=AZ69OczH6-8DAyAu-wDQ&pullRequest=506

Check failure on line 368 in server/tests/tasks/test_change_gating_handler.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this argument; Function "_live_fingerprints" expects a different type

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69OczH6-8DAyAu-wDR&open=AZ69OczH6-8DAyAu-wDR&pullRequest=506

Check failure on line 223 in server/services/change_gating/verdict.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Oc066-8DAyAu-wDV&open=AZ69Oc066-8DAyAu-wDV&pullRequest=506

Check failure on line 20 in server/services/change_gating/diff_utils.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 42 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Oc1A6-8DAyAu-wDW&open=AZ69Oc1A6-8DAyAu-wDW&pullRequest=506

Check failure on line 304 in server/tasks/change_gating.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 128 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=Arvo-AI_aurora&issues=AZ69Oc2B6-8DAyAu-wDZ&open=AZ69Oc2B6-8DAyAu-wDZ&pullRequest=506