Skip to content

Improve display of long strings - #39

Closed
laurentalsina wants to merge 1 commit into
ArthurSonzogni:mainfrom
laurentalsina:improve-display-of-long-strings
Closed

laurentalsina wants to merge 1 commit into
ArthurSonzogni:mainfrom
laurentalsina:improve-display-of-long-strings

Conversation

@laurentalsina

Copy link
Copy Markdown

when a string is very long, json-tui would fill the screen and not be able to show the whole text, this change chunks long strings, shows only the first chunk, and allows opening & closing chuncks one by one, this helps screen navigability as well as string readability

@laurentalsina

Copy link
Copy Markdown
Author

the PR is #39

@ArthurSonzogni

Copy link
Copy Markdown
Owner

Thanks for this, and sorry for the slow review.

I ended up going a different way in #41: strings stay on one line and scroll
horizontally, instead of expanding on click. It keeps every value one row tall,
which makes the layout predictable at any width. \n now renders as a real
line break, so long values are still readable.

Closing in favor of #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants