Skip to content

Diffmahnet updates alex and bug fix #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgezch merged 4 commits into from
Jul 10, 2026
Merged

Diffmahnet updates alex and bug fix #43

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0729a2d
updates to diffmahnet
georgezch May 15, 2026
159bec8
Merge branch 'main' of https://github.com/ArgonneCPAC/diffhalos
georgezch Jul 5, 2026
3bd8800
adding diffmahnet log_prob and fixing circ import bug
georgezch Jul 5, 2026
148aa42
removing new log_prob diffmahnet from PR
georgezch Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions diffhalos/mah/diffmahnet_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

from . import diffmahnet


DEFAULT_MAH_UPARAMS = get_unbounded_mah_params(DEFAULT_MAH_PARAMS)

__all__ = (
Expand Down Expand Up @@ -172,6 +171,7 @@ def get_mah_from_unbounded_params(
mah_params_unbound,
logt0,
t_grid,
m_vals,
):
"""
Helper function to generate the MAH from
Expand All @@ -190,6 +190,9 @@ def get_mah_from_unbounded_params(
t_grid: ndarray of shape (n_t, )
cosmic time grid at which to compute the MAH

m_vals: ndarray of shape (n_halo, )
correct mass values for rescaling the MAH parameters

Returns
-------
log_mah: ndarray of shape (n_halo, n_t)
Expand All @@ -204,9 +207,15 @@ def get_mah_from_unbounded_params(
)

mah_params_uncorrected = DEFAULT_MAH_PARAMS._make(mah_params_bound)

_, log_mah = mah_halopop(mah_params_uncorrected, t_grid, logt0)

# rescale mah parameters
delta_logm_obs = log_mah[:, -1] - m_vals
logm0_rescaled = mah_params_uncorrected.logm0 - delta_logm_obs
mah_params_corrected = mah_params_uncorrected._replace(logm0=logm0_rescaled)

_, log_mah = mah_halopop(mah_params_corrected, t_grid, logt0)

return log_mah


Expand Down
Loading